Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Looks like the border:0; in the reset kills the border in IE7 totally, which looks very odd (button floating in space, no indication this is a text field.
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | imagefield-upload-widget.png | 21.21 KB | reglogge |
| #10 | seven-reset-ie7-876982.patch | 940 bytes | wapnik |
| #8 | seven-reset-ie7-876982.patch | 415 bytes | wapnik |
| #4 | seven-reset-ie7-876982.patch | 370 bytes | wapnik |
| #1 | seven.reset.css.patch | 388 bytes | wapnik |
Comments
Comment #1
wapnik CreditAttribution: wapnik commentedThe first rule of the reset.css file differs from the meyer's reset (http://meyerweb.com/eric/tools/css/reset/). Input, select and textarea are extra. Deleting these 3 selectors does seem to put ie in order. I don't see nothing else badly affected by this change, only that in ff it has changed a little bit, but at least it has a 1px border (not a 2px or 3px), like ie does.
Comment #2
wapnik CreditAttribution: wapnik commentedComment #4
wapnik CreditAttribution: wapnik commentednow with proper line endings and named accordingly
Comment #5
webchickUm. Yikes!
This is at least major, probably critical. Tagging to mark it for IE review.
Comment #7
wapnik CreditAttribution: wapnik commentedcan you tell me please what i'm doing wrong with the patch tests? a bad name? sorry i'm only a beginner
Comment #8
wapnik CreditAttribution: wapnik commentedanother try (changing directories)
Comment #9
Jeff Burnz CreditAttribution: Jeff Burnz commentedCan we wait on #849642: Regression: Absolute font-sizes used in Seven before making such a drastic change to the reset, in any case I'm not quite sure thats the right solution since there are other property values in the reset that may be affecting those elements - what is actually the problem here dude - why isn't IE getting the border (its explicitly set later on in the styles.css)?
Comment #10
wapnik CreditAttribution: wapnik commentedI found some styles down in the cascade in style.css applying for other input element classes, not for the file input, so i added the selectors there, and works fine.
One think is annoying me. Check the yui reset (http://yui.yahooapis.com/3.1.1/build/cssreset/reset.css). There is no border for the input, select and textarea elements, like in meyer's reset too. I would logically expect it to be set there, but not to zero.
Comment #11
Jeff Burnz CreditAttribution: Jeff Burnz commentedYeah, I agree, border: 0; in a reset seems draconian - this whole reset is rather OTT. I've been working on the font sizes patch and actually started by completely removing the reset and barely anything changed (some notable things did), I might even make it my goal to remove it completely. If you see that patch I actually removed two properties from the reset already...
Comment #12
wapnik CreditAttribution: wapnik commentedI'm quite a bit dissatisfied with the style structure of d7 core themes. I thought every core theme is using at least a reset and proper font sizes. Take a look at drupal zen theme for example. A good place for inspiration. I suggest to make the reset.css as close to meyer's reset (or the yui reset) as possible in first place. And it would be nice to have it for all core themes consistently.
Comment #13
webchickMy personal belief is reset.css is a complete cop-out, and its use in Seven is something I'd like to remove, not encourage. If Drupal's underlying CSS is making wrong assumptions, we should be fixing that, not working around it in every single theme.
But, it's too late for that now, so we just are stuck with fixing it.
Comment #14
Jeff Burnz CreditAttribution: Jeff Burnz commentedYeah, I'm with webchick here, I'm not a big fan of resets either - in the end you end up overriding 99% of it anyway and all you have is a big fat redundant block of code like Seven has. It also makes debugging in Firebug harder (scroll, scroll, scroll...). I used one once in one contrib theme (meyers) and never again - it caused as many issues as it solved.
Comment #15
reglogge CreditAttribution: reglogge commentedLet's get this specific and very ugly bug out of the way and discuss the pros and cons of reset.css in a follow up issue.
The fix works as advertised and also solves the even uglier appearance in Opera #890964: Widget for image-upload in Seven theme horribly broken. The screenshot from this issue is attached here for reference.
Comment #16
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks!
Marking is 'needs work' as we're still evaluating alternatives.
Comment #17
amateescu CreditAttribution: amateescu commentedFor D8, I suggest to use the css reset from HTML5 Boilerplate: https://github.com/paulirish/html5-boilerplate/blob/master/css/style.css.
I've been working with it for a few months with excellent results.
Comment #18
Jeff Burnz CreditAttribution: Jeff Burnz commented@17 - that needs to be discussed in a new issue really (the reset issue). Lets leave at D7 for now, no reason why a different fix might not get in a point release etc (although I agree that is probably unlikely).
We need to leave the status for Dries et al to know this needs work, as mentioned in #16, also there is nothing to review (which is for when a patch is submitted for review).
Comment #19
amateescu CreditAttribution: amateescu commentedOk, sorry for derailing..
Comment #20
webchickIs there anything left to follow-up with in D7 though? Removing reset.css isn't something we can do this late. What other alternatives are there?
Comment #21
Jeff Burnz CreditAttribution: Jeff Burnz commentedIMO for D7 there are no alternatives and we can probably mark this as fixed and be done with it, removing the reset is a pretty big task and probably needs its own new issues in any case. Sorry, I don't know why I set this back to needs work, must have been really tired + brain fart.