At the top of /admin/modules it says "Download additional contributed modules to extend Drupal's functionality."

If you follow the link, it displays all modules, including Drupal 5 and 6 modules that simply don't apply, and will not work for the unsuspecting user. So simply start by presenting only the Drupal 7 modules.

CommentFileSizeAuthor
#9 system[D8]-add_filter_for_module_listing-875402-9-do-not-test.patch2.92 MBsourabh.singhal
#4 system-add_filter_for_module_listing-875402-2-do-not-test.patch1.3 KBsourabh.singhal
#2 system-add_filter_for_module_listing-875402-2.patch1.3 KBsourabh.singhal
filter_module_list.patch1.08 KBberenddeboer
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sourabh.singhal’s picture

sourabh.singhal CreditAttribution: sourabh.singhal as a volunteer and at Faichi Solutions Pvt Ltd for Faichi Solutions Pvt Ltd commented
Assigned: Unassigned » sourabh.singhal
Issue summary: View changes
sourabh.singhal’s picture

sourabh.singhal CreditAttribution: sourabh.singhal as a volunteer and at Faichi Solutions Pvt Ltd for Faichi Solutions Pvt Ltd commented
Status: Active » Needs review
FileSize
system-add_filter_for_module_listing-875402-2.patch1.3 KB

Hi berenddeboer,

That's really a great initiative, I tried your patch but it's not working, I debug this and found some changes, attaching the patch file.

Please review.

Thanks
Sourdrup

Status: Needs review » Needs work

The last submitted patch, 2: system-add_filter_for_module_listing-875402-2.patch, failed testing.

sourabh.singhal’s picture

sourabh.singhal CreditAttribution: sourabh.singhal as a volunteer and at Faichi Solutions Pvt Ltd for Faichi Solutions Pvt Ltd commented
Status: Needs work » Needs review
FileSize
system-add_filter_for_module_listing-875402-2-do-not-test.patch1.3 KB

Since my last patch was failed, I double checked, it is applying correctly, the changes works well so I am uploading a new patch file again. Please review

billywardrop’s picture

billywardrop CreditAttribution: billywardrop as a volunteer commented

I have reviewed and tested the patch file in #4. It works in Drupal 7.50 and drupal 7.52.

billywardrop’s picture

billywardrop CreditAttribution: billywardrop as a volunteer commented
Status: Needs review » Reviewed & tested by the community

The last submitted patch, filter_module_list.patch, failed testing.

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein as a volunteer commented
Version: 7.x-dev » 8.3.x-dev
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs backport to D7

Interesting, I think that makes sense. But let's do the equivalent for Drupal 8 first, and then backport.

sourabh.singhal’s picture

sourabh.singhal CreditAttribution: sourabh.singhal as a volunteer and at Faichi Solutions Pvt Ltd for Faichi Solutions Pvt Ltd commented
Status: Needs work » Needs review
FileSize
system[D8]-add_filter_for_module_listing-875402-9-do-not-test.patch2.92 MB

Thanks David_Rothstein,

Here is the patch for D8. Please review.

Thanks
Sourdrup

billywardrop’s picture

billywardrop CreditAttribution: billywardrop as a volunteer commented

Sorry I'm still quite new to contributing. David_Rothstein are you saying your happy it works in 7 but would prefer to have a patch in Drupal 8 first then back port it?

sourabh.singhal’s picture

sourabh.singhal CreditAttribution: sourabh.singhal as a volunteer and at Faichi Solutions Pvt Ltd for Faichi Solutions Pvt Ltd commented

Hi billywardrop,

That's only the reason I have submitted the patch for Drupal 8 too.

Thanks
Sourdrup

billywardrop’s picture

billywardrop CreditAttribution: billywardrop as a volunteer commented

Ah I see, do you want me to test the D8 patch?

sourabh.singhal’s picture

sourabh.singhal CreditAttribution: sourabh.singhal as a volunteer and at Faichi Solutions Pvt Ltd for Faichi Solutions Pvt Ltd commented

Hi billywardrop,

Yes sure.

Thanks

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein as a volunteer commented
Title: When visiting list of contributed modules, filter by version 7 » When linking to the list of contributed modules, filter by Drupal version
Status: Needs review » Needs work

David_Rothstein are you saying your happy it works in 7 but would prefer to have a patch in Drupal 8 first then back port it?

Right. Except in unusual situations the policy is to fix issues in the newest release first and then backport afterwards (see https://www.drupal.org/core/backport-policy for more information).

The Drupal 8 patch looks like it accidentally included a lot of other changes, so I'm moving this back to "needs work". Also, please remove the "do-not-test" from the filename when a new patch is uploaded, so that the testbot will run on it. Thanks!

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein as a volunteer commented

By the way, there are a lot of other places in the codebase that link to https://www.drupal.org/project/modules also, as well as some that link to https://www.drupal.org/project/themes (such as the admin/appearance page). Should we change those here too?

billywardrop’s picture

billywardrop CreditAttribution: billywardrop as a volunteer commented

I think we need to change those as well. If we dont, that may confuse people. I tried running the patch in Drupal 8 but I get errors when I run it. For every file it says "error patch failed" or "patch does not apply".

Also, is there a reason why the patch is 2.92Mb compared to the Drupal 7 patch of 1.3k?

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.