Missed call of then file_delete [#873028]

Uploading a file to a node without saving the node, the file_insert-function is called. deleting the file directly from the node, file_delete-function is not called. without the callback-function other modules cannot cleanup things they did on insert

i think the problem is in filefield_delete_file_references:
i changed the lines

    // Do not update a node if it is already being deleted directly by the user.
    if (isset($file->delete_nid) && $file->delete_nid == $nid) {
      continue;
    }

    // Do not update a node if it is already being deleted directly by the user.
    if (isset($file->delete_nid) && $file->delete_nid == $nid) {
      field_file_delete($file);
      continue;
    }

Comments

Comment #1

quicksketch

he/him

CreditAttribution: quicksketch commented 3 August 2010 at 20:51

Thanks for the report. Could you clarify the workflow that causes this problem?

Comment #2

aegluke CreditAttribution: aegluke commented 3 August 2010 at 21:18

I have a content type with a filefield. uploading a file to a node and then (without saving the node) removed the file via the ajax-upload-formular.
file_insert is called direct on upload. file_delete is never called.

it works only correct if i upload the file - save the node - and then edit the node again and remove the file.

Comment #3

quicksketch

he/him

CreditAttribution: quicksketch commented 4 August 2010 at 06:17

Perfect! Thanks.

Comment #4

quicksketch

he/him

CreditAttribution: quicksketch commented 6 December 2010 at 02:20

Status:

Active

» Postponed (maintainer needs more info)

Upon trying to test this out, I could not reproduce a problem. The problem described is that field_file_delete() is not called when removing a file from an unsaved node. However the suggested fix would cause an infinite loop if implemented, since field_file_delete() is the function that calls filefield_delete_file_references() in the first place. The call stack is as follows:

field_file_delete()
module_invoke_all('file_delete')
filefield_file_delete()
filefield_delete_file_references() // Calling field_file_delete() here would cause a loop.

I double checked that hook_file_delete() is called when removing files on unsaved nodes and was unable to reproduce a problem, hook_file_delete() is always called regardless the state of the node or when the file was removed.

Comment #5

teknic CreditAttribution: teknic commented 11 January 2011 at 21:46

I think I am able to reproduce this.

I upload a file to a file field, save the node... come back to the node edit page and click remove on the file field upload widget, the hook_file_delete is never called the first time.

Comment #6

quicksketch

he/him

CreditAttribution: quicksketch commented 11 January 2011 at 22:17

I upload a file to a file field, save the node... come back to the node edit page and click remove on the file field upload widget, the hook_file_delete is never called the first time.

Clicking "Remove" on the file field doesn't fire hook_file_delete() until the node is saved. Even then it's not called if the file is in use multiple places through a module like FileField Sources. It is only called if the file is actually being removed from disk when it is no longer referenced by any content.