Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I use this theme,when I active gravatar modules,home page and node active comment will display incorrect,but book page,and other no comment node is correct.
Comment | File | Size | Author |
---|---|---|---|
#9 | 872392-gravtar-external-image-theme.patch | 672 bytes | zyxware |
correct.jpg | 75.43 KB | 423300 | |
incorrect.jpg | 41.88 KB | 423300 |
Comments
Comment #1
423300 CreditAttribution: 423300 commentedI use this theme:
http://drupal.org/project/tarski
when I active gravatar modules,home page and node active comment will display incorrect,but book page,and other no comment node is correct.
Comment #2
mariusz.slonina CreditAttribution: mariusz.slonina commentedAlso happens in Bartik theme, after default, fresh installation
Comment #3
chrissearle CreditAttribution: chrissearle commentedSame here. If you go to the user page with gravatar enabled you see
Fatal error: Call to a member function getDirectoryPath() on a non-object in [path_to_site_install]/modules/image/image.module on line 809
Comment #4
Narno CreditAttribution: Narno commented@chrissearle, duplicate issue: http://drupal.org/node/937562
Comment #5
chrissearle CreditAttribution: chrissearle commented@Narno Thanks for the link :)
Comment #6
chrissearle CreditAttribution: chrissearle commentedOK - after update to beta2 I can now set a default pic as described in http://drupal.org/node/937562 without breaking the site. I don't see the image on any posts or the user pages though - so something there is still odd (I used the example given - http://images.adbard.net/sites/default/files/audience_1.png)
The 2010-Aug-14 7.x-1.x gravatar is still giving the error about getDirectoryPath() - line 809 in image module.
$url = url(file_stream_wrapper_get_instance_by_scheme($scheme)->getDirectoryPath() . '/' . file_uri_target($destination), array('absolute' => TRUE));
Comment #7
chrissearle CreditAttribution: chrissearle commentedhttp://drupal.org/node/950348 for non-display of default pic
Comment #8
chrissearle CreditAttribution: chrissearle commentedJust tested in D7 beta3 - still seeing the error about getDirectoryPath(). http://drupal.org/node/937562 is marked fixed in CVS head over a month ago - so I assume that fix has made it in to at least the latest beta.
Comment #9
zyxware CreditAttribution: zyxware commentedThe patch mentioned in #937562: [Regression] Fatal Error Call to a member function getDirectoryPath() on a non-object when Default picture is set has gone into D7 beta 3. This error is due to an error in the gravtar module itself. In the gravatar_preprocess_user_picture function theme('image_style', ... is called for an external URI. The check on file_valid_uri($picture) should be done here as well.
I have changed the title of the issue to reflect the error message
I am attaching a patch that adds the file_valid_uri check before calling the image_style theme function.
Comment #10
zyxware CreditAttribution: zyxware commentedChanging status
Comment #11
jackread CreditAttribution: jackread commentedthis patch fixed the problem for me
Comment #12
Dave ReidThanks! Committed #9 to CVS!
http://drupal.org/cvs?commit=456396
Comment #13
Dave Reid