Wrong return value on field_info_fields() [#863370]

Quote from modules/field/field.info.inc, lines 517 to 524:

/**
 * Returns all field definitions.
 *
 * @return
 *   An array of field definitions, keyed by field name. Each field has an
 *   additional property, 'bundles', which is an array of all the bundles to
 *   which this field belongs keyed by entity type.
 */

But, if $info gets no values the return value was NULL, instead of array() because the $fields variable is created insite the foreach.

Comment	File	Size	Author
#6	863370-fields.patch	662 bytes	andypost
#6
#4	field-info-fields-863370-4.patch	648 bytes	bjaspan
#4
	field.info_.inc-wrong_return_on_field_info_fields.patch	598 bytes	dmonroy

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

bjaspan CreditAttribution: bjaspan commented 24 July 2010 at 16:56

Status:

Active

» Reviewed & tested by the community

Looks good. We could perhaps add a test for this but this is an extremely common code pattern in Drupal so I do not think it is necessary. But anyone wanting a bonus point could write one. Call field_info_fields(), delete all the fields it returns, and call it again, making sure it returns array() the second time.

Comment #2

24 July 2010 at 17:10

Status:

Reviewed & tested by the community

» Needs work

The last submitted patch, field.info_.inc-wrong_return_on_field_info_fields.patch, failed testing.

Comment #3

dmonroy CreditAttribution: dmonroy commented 24 July 2010 at 18:30

Steeps to reproduce the error i receive:

1. Install a clean Drupal 7 Alpha 6
2. Install Views (7.x-3.x-dev)
3. Go to views admin page

You will receive a warning on "..views/modules/field.views.inc" line 20, because we expect an array value, as explained on field_info_fields() documentation.

/**
 * Fragment of views/modules/field.views.inc
 **/

/*19*/    $data = array();
/*20*/    foreach (field_info_fields() as $field) { # <-- This is the line
/*21*/      if ($field['storage']['type'] != 'field_sql_storage') {

I think, this is not a views bug, because documentations say, the return value is an array.

Maybe it's something trivial, I did not like the warning shows