Port to Drupal 7

I get the same thing. I really liked this theme in D6 because of its lightweightness, and I would like to continue using it in D7 as well.

Now that there's a D7 beta out, let's get working on this!

Is this project no longer maintained?

I also get many "undefined" errors in D7, including the following:

Undefined variable: rdf_namespaces in include()

Here's some beginning patches. They get stuff working mostly. You'll still get an error about $search_box being undefined. I haven't decided what to do with that yet.

Changes summary:
- page template variables have changed
- removed stuff from the page template that is redundant with system's html.tpl.php
- block template content variable changed
- added stylesheet to .info file as it is now required

Also, remove box.tpl.php file as it is no longer used.

(I should really get a better development environment set up so I can make better patches...)

Thanks! I tried this, but instead of getting the page content, most things seem to appear as "Array" instead. I looked at the code myself and it doesn't appear to be printing things any differently than Garland, so I am confused.

OK, I got the tabs working. There should be a render() around the $tabs variable on line 50.

I have found that the "Array"s instead of content is caused by node.tpl.php not being patched. I updated it to display properly. Do you want me to post a patch?

Yea, I noticed that a lot of the template variables are now arrays and not strings so they need render() around them. I haven't dug into all of them yet and haven't gotten to node.tpl.php yet. I was trying to hit the higher level stuff first based on what's in http://drupal.org/update/theme/6/7. Go ahead and post a patch for node.tpl.php. Be sure to also add in $title_prefix and $title_suffix around the $title in node.tpl.php too (see page.tpl.php).

For the Drupal newbies not familiar with patching, can you go over the steps required to install a patch on a Mac? Thanks.

I have been doing alot of work on this, and I now have most everything working. The only thing I can't get is putting the primary and secondary menus in the header on the same line with the site name. I will post patches when I get a chance.

ithacaindy,

Check here http://drupal.org/patch/apply and here http://drupal.org/node/60818

OK, here is the patch with everything Sborsody did and everything I have done so far. Everything I have tested works correctly, including the primary/secondary menus that I was complaining about earlier. In order to get the menu system working, I had to add some CSS. Previously, the left-side menus were indented way too far causing some of the menu items to be invisible. I also had to add some CSS to get the header menus to work. All the HTML is XHTML+RDFa 1.0 compliant and the CSS is CSS3 compliant, as tested by the W3C validator.

The only remaining problem I have found is that the white background behind the main pane does not extend to the bottom of the page (in conditions where the sidebar(s) is/are longer than the main section) as they should. This appears to be a defect in the original tableless conversion of the theme, and not in my work. I am not that great with CSS, so I don't know how to fix it.

To apply the patch, just place it in the bluemarine folder and execute "patch -p1 < bluemarine-d7.patch"

I applied the patch and installed the bluemarine d7 as my default theme. Everything seems to work, except I get this error:

Notice: Undefined variable: search_box in include() (line 5 of public_html/d7/sites/all/themes/bluemarine/page.tpl.php).

OK, here is an updated version of the patch. Here are the changes since the last patch:

• All references to $search_box have been removed, as it is obsolete in D7. I added/updated styling for the search block so that if it is put in the header it will appear as it did in D6.
• Styling has been added for vertical tabs.
• The forum topics view has been fixed to match the forums view. It is something of a hackish workaround in the CSS, though. This must be done because the forum topics use the CSS class "title", which by default has very large text and different link colors
• Possibly other things. I have been working on this really hard. :)

@ithacaindy, this will fix your problem.

Here is another small update to my patch. This fixes an issue relating to the search button and also adjusts the spacing of the search box.

My patches are cumulative, so you should unapply all previous patches before applying the new one.

Oops, forgot the file.

Yet another small fix. node.tpl.php now checks to make sure there are actually links to be printed before printing "»"

Here is another group of small fixes.

• The links to download and review the release notes of modules on the module update page have been fixed. Before, they were displaying as a vertical bullet list instead of the horizontal list they should have.
• The row color on the Status Report page has been changed to match the color of the module update table.
• comment.tpl.php now checks to see if there are links (like #19) before displaying the ». I am not sure if the original theme posted here ever tried to do that, but the current method matches how things seem to work on the Bluemarine theme at themegarden.org

At this point, the only defect I know of is the main section length I mentioned in #13.

I am also wondering if the maintainer of this theme is around to commit this?

This issue is critical, considering that the theme does not work at all in its current state.

I found a site where someone has done what I am attempting to do (have the side divs extend the full height of the page), but I am not good enough at CSS to understand what he is doing.

http://www.wickham43.net/backgroundsfullheight2col.html

Wow. Good start, Stacey and Michael!

I've committed the latest patch and also done some additional cleanup. Not sure if its 100% done, but it should be very close.

Thanks for committing this! But, I was wondering why you removed

.version-links .links li {
  text-align: right;
  display: inline;
  list-style: none;
  padding-left: 3px;
  padding-right: 3px;
}

table.system-status-report tr.ok{
  background-color: #dfd;
}

from the CSS.

Also, here is another small patch to correct two issues with the search box caused by the addition of the contextual links and changes in the block.tpl.php file.

If the search block is placed in the header and its title is set to "Search this site:", then the header will just just about the same as D6.

I've noticed that the -dev version does not output the class="title" that it used to on some/all h2 tags. This breaks several things, including the node titles on the front page and the search box (worked around in CSS with #25). Is this intended, or is it a bug?

@mamarley: The -dev release is created every 12 hours if there are recent commits. The one you downloaded was actually created in the middle of the updates that I did, so it's out-of-date. You'll either need to get it from CVS or wait 12 hours for the updated one. Your patch won't apply.

It appears that previously, class="title" was hardcoded into the tpl.php files. Since several areas of the CSS depend on this, maybe it should be added back?

Checking out CVS now, sorry :)

Thanks! I just updated from cvs. I'll take care of that length issue in #13.

Hrm, I didn't even realize that the D6 version uses tables for layout!

Thanks! Let me know what you find, because I have also forked off a "redmarine" theme for my own site that I want to update as well.

Thoughts...

I started to work on fixing the floated divs to make them equal height columns. I planned on implementing the sliding door technique. To achieve good results requires using template.php to detect how many columns there are so that the widths on the columns can be correctly set. But that's when I started to cringe, believing that this theme shouldn't have a template.php. My view of this theme is that it is supposed to be simple and lightweight and that admins use it for when they don't want a lot of bells and whistles and want things to "jfw". Floated divs create a kind of complexity that may not be wanted by users of this theme.

I don't understand the reasoning behind converting this theme from a table-based layout to floated divs and I'd like to (I tried to look in cvs for any comments related to this). Was there some discussion that I missed? The D6 version is a multi-column table-based layout. Therefore I'm kind of surprised to learn of the change away from that primary layout method. Wouldn't the continuation of the table-based layout be expected in the D7 version? I would have said something earlier, but I didn't look close enough at the D6 version to see the difference.

It appears that previously, class="title" was hardcoded into the tpl.php files.

Right, but we can no longer hardcode a class attribute because it could be a part of the $title_attributes variable. So I added the "title" class back in using preprocess functions. Thanks for pointing this out.

But that's when I started to cringe, believing that this theme shouldn't have a template.php.

Too late! :-D

I don't understand the reasoning behind converting this theme from a table-based layout to floated divs

It happened in core before I volunteered to port it to D7 as a contrib theme. See #200685: GHOP #92: Convert bluemarine to a tableless layout

I started to work on fixing the floated divs to make them equal height columns.

I was actually surprised how easy this was to implement with some CSS. I gave the .layout-columns container a white background and set it to use margins instead of padding. Boom. Done. Here's the patch I already committed. I haven't done cross-browser testing on it though.

Another issue I found with the new theme's CSS is that ".sticky" should be ".node-sticky" now. The sticky nodes aren't appearing with a gray background like they should.

Heh, yea, setting a white background was what I started with :)

I didn't see much discussion about the why for converting to a table-less layout in that issue. I did see the issue of equal-height columns come up there too.

I got distracted last night and couldn't offer a patch. I have a different idea this morning for still trying to do sliding door without template.php. It looks like the necessary body classes are already generated by default D7.

Separate issue:

There's some padding or margin to the right on the whole page in IE.

Here's a patch for the IE right-padding issue. Something about the way the menu headers are hidden makes IE do that. The solution was just to remove theming the menu headers.

I also hid the skip link.

We should probably identify tasks that need yet to be completed for this port.

Changed .sticky to .node-sticky.

@sborsody: I can't add the patch in #38. That removes accessibility features for menu navigation and for skip links. Also, I don't see the padding issue in IE8; with a right sidebar or without. Can you open a new issue with steps to reproduce?

Ok. I'm calling it! Drupal 7.0 was released yesterday. I'm rolling a 7.x-1.0 release now. :-) Thanks again for all your help!

Have the docs been updated? I'd like to know how to make a content-sidebar-sidebar layout.

How can I use #34 to get different coloured sidebars of the same height as the main column?

And to make a really ugly example lets say:
I want a pink header.
A gren left colomn, A yellow middle column and a red right column
A blue body.

Im not able to make this work.
The header and body is easy. I have figured out how to fix the main column to but im not able to get the side columns to fill with their colors. I can get active blocks in each column to get the right color but that leaves blocks of the wrong color (ie body) wisable above the footer and I want them to be filled with the column color.

As I read this thread I belive that #34 should make this possible but is it documented anywhere how to do it?

The patch in #34 has already been added to the theme.

This is a closed issue. If you have a new question/issue, then open a new issue.