Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
aren't we doing the array addition twice here?
$curl_options = $this->additionalCurlOptions + array(
CURLOPT_COOKIEJAR => $this->cookieFile,
CURLOPT_URL => $base_url,
CURLOPT_FOLLOWLOCATION => FALSE,
CURLOPT_RETURNTRANSFER => TRUE,
CURLOPT_SSL_VERIFYPEER => FALSE, // Required to make the tests run on https.
CURLOPT_SSL_VERIFYHOST => FALSE, // Required to make the tests run on https.
CURLOPT_HEADERFUNCTION => array(&$this, 'curlHeaderCallback'),
CURLOPT_USERAGENT => $this->databasePrefix,
);
if (isset($this->httpauth_credentials)) {
$curl_options[CURLOPT_HTTPAUTH] = $this->httpauth_method;
$curl_options[CURLOPT_USERPWD] = $this->httpauth_credentials;
}
curl_setopt_array($this->curlHandle, $this->additionalCurlOptions + $curl_options);
Comment | File | Size | Author |
---|---|---|---|
#1 | drupal_web_test_case.php_.patch | 812 bytes | glipay |
Comments
Comment #1
glipay CreditAttribution: glipay commentedI removed the first aray addition so the current behavior would be maintained, but I don't completely understand what this code is doing, so maybe it's more appropriate to remove the second array addition, I don't know.
Comment #2
Anonymous (not verified) CreditAttribution: Anonymous commentedlooks fine to me, simple patch, RTBC.
Comment #3
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.