Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Fixing newlines
Comment | File | Size | Author |
---|---|---|---|
#4 | 855418-cleanup.patch | 9.46 KB | jhodgdon |
newline_xmlrpc_inc.patch | 1.76 KB | aspilicious | |
Comments
Comment #1
jhodgdonIn some of your other patches, you also corrected missing . at ends of @param or @return lines. This patch has some missing. Want to fix them too?
Also, if you are doing that:
Needs expansion - what type of object?
Comment #2
aspilicious CreditAttribution: aspilicious commentedand
Are the code parts for the incomplete headers.
There are even some undocumented functions in that class...
So I'll leave this patch needs work for now and I'm changing the title.
Would be nice if the coder of that part could fix this.
Comment #3
jhodgdonOK, I'll take it on.
Comment #4
jhodgdonHere's a first go at the more comprehensive patch. No longer "minor".
Comment #5
jhodgdonComment #6
aspilicious CreditAttribution: aspilicious commentedRead through the docs with dreditor.
This is ready to go.
Jhodgdon++
Comment #7
aspilicious CreditAttribution: aspilicious commentedWhoops, reading it again.
Must there be a "TRUE" before on success?
Comment #8
jhodgdonNo, it returns the response on success, and FALSE on failure.
Comment #9
aspilicious CreditAttribution: aspilicious commentedOk, RTBC after all
Comment #10
Dries CreditAttribution: Dries commentedCan we combine all newline patches into one patch, please?
Comment #11
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.