In styles, numerical values are saved and strings and passed to JS as strings. [#853342]

I was having some issues implementing graphical markers on a vector layer. I trace the bug to the fact that the offsetX and offsetY where being paseed to the OpenLayers JS as strings. It then does something like:

(offsetX + 20).toFixed();

The toFixed() call fails because the part in the parens is evaluated as a string. As a quick fix, I form_altered the style ui form and added a submit handler that runs all the integer 'data' values through intval(). I suspect that a better solution is to properly prepare the data before it is rendered as javascript?

Comments

Comment #1

zzolo CreditAttribution: zzolo commented 13 July 2010 at 22:00

Hey @te-brian. Thanks for the catch, but this should already be fixed in the dev version. Can you try this out?

Comment #2

batje CreditAttribution: batje commented 15 July 2010 at 17:43

That fixed it for me. thanx.

Comment #3

tmcw CreditAttribution: tmcw commented 15 July 2010 at 17:56

Status:

Active

» Closed (fixed)

Great, closing this issue.

Comment #4

batje CreditAttribution: batje commented 30 July 2010 at 15:51

Status:

Fixed

» Active

reopening.

This does fix the issue with number, but now, if you enter

${yourfieldnameofchoice}

and press save, the form returns with a value of 0.

And, not sure if this should be a seperate ticket, its very close though.

if you fill in the 'externalGraphic' field, the string value is stored correctly. But during rendering, nothing is done with the value. its just inserted plain into the javascript.

Comment #5

tmcw CreditAttribution: tmcw commented 30 July 2010 at 15:34

Version:	6.x-2.0-alpha8	» 6.x-2.x-dev
Status:	Closed (fixed)	» Active

Callback functions are currently not supported in this module, because we're working on an implementation based around flexible plugins. Supporting enforced-numbers sometimes and callbacks other times won't happen in the releases, for sure, but if you need this functionality, you can export a style and edit the export.

Comment #6

zzolo CreditAttribution: zzolo commented 30 July 2010 at 15:34

Status:

Active

» Fixed

Good catch. Should be fixed in this commit, by not casting strings of form "${attr}"
http://drupal.org/project/cvs/177400

Comment #7

zzolo CreditAttribution: zzolo commented 30 July 2010 at 15:36

Side note, @tmcw, that syntax works for attribute replacement as well, so if you add fields to a view, and it was working before I made the casting update.