Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Correct version attached.
Comment | File | Size | Author |
---|---|---|---|
#1 | extend_is_broken_beyond_recognition_and_oop_is_not_far_behind.patch | 1.28 KB | chx |
extend_is_broken_beyond_recognition.patch | 718 bytes | chx | |
Comments
Comment #1
chx CreditAttribution: chx commentedGrrrrr!
Comment #2
Anonymous (not verified) CreditAttribution: Anonymous commentedwow, nasty. so, we have broken code, fixed by a broken patch, and the testbot was happy both times. think that's the definition of needing tests.
Comment #3
Crell CreditAttribution: Crell commentedThe problem is that this code is really hard to test without a completely custom DB driver. I don't think we could manage that easily.
That said, this is definitely a bug. In fact I remember fixing it a year ago, so I don't know why it's still here. Oh well. #1 is the correct fix, and looks RTBC to me.
It's not critical, though, as none of the core-supported DB drivers break from this.
Comment #4
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.
Comment #5
sunCode comments would have helped to at least explain the WTF to some extent. Just reading the patch... still WTF. "Glad it works for you."
Comment #6
Damien Tournoud CreditAttribution: Damien Tournoud commentedBasically, the old version was checking for the following classnames:
instead of: