Reset to alphabetical produces Fatal error [#851042]

I was looking at this issue #846524: Terms cannot be manually reordered by weight. and decided to see what happened when I clicked on the 'Reset to alphabetical' link at the bottom of the page. Well, let's just say it isn't good.

So from here admin/structure/forum after confirming you get:

Fatal error: Call to undefined function taxonomy_overview_terms_submit() in /home/dm7/includes/form.inc on line 1160 Call Stack: 0.0002 60920 1. {main}() /home/dm7/index.php:0 0.0467 2021016 2. menu_execute_active_handler() /home/dm7/index.php:22 0.0470 2048096 3. call_user_func_array() /home/dm7/includes/menu.inc:476 0.0470 2048180 4. drupal_get_form() /home/dm7/includes/menu.inc:0 0.0470 2048348 5. drupal_build_form() /home/dm7/includes/form.inc:181 0.0484 2061288 6. drupal_process_form() /home/dm7/includes/form.inc:328 0.0525 2165588 7. form_execute_handlers() /home/dm7/includes/form.inc:743

Comment	File	Size	Author
#4	851042-alphabetical-reset.patch	493 bytes	dawehner
#4
#3	fatal.patch	744 bytes	catch
#3

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

catch

he/him

English

CreditAttribution: catch commented 12 July 2010 at 01:17

http://api.drupal.org/api/function/taxonomy_overview_terms_submit/7 does exist, but it's in taxonomy.admin.inc

Should be an easy enough fix - either require the file, or move the function into taxonomy.module

Comment #2

catch

he/him

English

CreditAttribution: catch commented 12 July 2010 at 04:39

I don't get a wsod with this, but I do get:

Notice: Undefined index: #page_increment in theme_taxonomy_overview_terms() (line 552 of /home/catch/www/7/modules/taxonomy/taxonomy.admin.inc).
Notice: Undefined index: #page_entries in theme_taxonomy_overview_terms() (line 553 of /home/catch/www/7/modules/taxonomy/taxonomy.admin.inc).
Notice: Undefined index: #back_step in theme_taxonomy_overview_terms() (line 554 of /home/catch/www/7/modules/taxonomy/taxonomy.admin.inc).
Notice: Undefined index: #forward_step in theme_taxonomy_overview_terms() (line 555 of /home/catch/www/7/modules/taxonomy/taxonomy.admin.inc).
Notice: Undefined index: #parent_fields in theme_taxonomy_overview_terms() (line 558 of /home/catch/www/7/modules/taxonomy/taxonomy.admin.inc).

This is with overlay enabled.

Comment #3

catch

he/him

English

CreditAttribution: catch commented 12 July 2010 at 04:49

Status:

Active

» Needs work

File	Size
fatal.patch	744 bytes

Adding $form_state['build_info']['file'] forces the file to be included when the submit handler runs. However it also looks like the confirm form is completely broken too - it shows no terms in the vocabulary on the confirm screen, which is likely the cause of those notices.

Comment #4

dawehner

German

CreditAttribution: dawehner commented 12 July 2010 at 06:51

Status:

Needs work

» Needs review

File	Size
851042-alphabetical-reset.patch	493 bytes

A quote from forum_overview:


  // Remove the alphabetical reset.
  unset($form['reset_alphabetical']);

So my suggestion for a patch.

Comment #5

catch

he/him

English

CreditAttribution: catch commented 12 July 2010 at 06:54

Status:

Needs review

» Reviewed & tested by the community

Ooh much better.

I was going to say this needs a test, but checking that page for the non-existence of the reset to alphabetical button seems a bit much, so let's just get this in.