When we added color module support for the site name and slogan, it hijacked the maintenance page header styling as well. (Dang you colormodule!)

When the site name is white (which it is by default) it "disappears" from the maintenance page. The solution is to make the maintenance page styling more specific and override the color module settings.

CommentFileSizeAuthor
#1 850940.patch1.06 KBjensimmons
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jensimmons’s picture

jensimmons CreditAttribution: jensimmons commented
Status: Active » Needs review
FileSize
850940.patch1.06 KB

Before:

After:

eigentor’s picture

eigentor CreditAttribution: eigentor commented
Status: Needs review » Active

Yeah noticed this as well. How about making the maintenance page text all hardcoded black? If someone recolors the site title to match corporate colors, this should be maintained somehow, though.

jensimmons’s picture

jensimmons CreditAttribution: jensimmons commented
Status: Active » Needs review
jensimmons’s picture

jensimmons CreditAttribution: jensimmons commented

For context, this is what the whole page looks like:

bleen’s picture

bleen CreditAttribution: bleen commented
Status: Needs review » Reviewed & tested by the community

RTBC

eigentor’s picture

eigentor CreditAttribution: eigentor commented

Hm, shouldn't we also show the logo? Companies will like their maintenance page branded.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

I agree with eigentor.

bleen’s picture

bleen CreditAttribution: bleen commented

I think we have the same color problem in that case ... imagine a white Nike Swoosh as the company logo. It will appear as a weird giant blank space.

We would have to add full color module support to the maintenance page for this to work... blech.

Also note that this page shows when the database is unreachable ... I dont think this would effect color module settings (?), but it does severely limit what we can do with this page in general.

jensimmons’s picture

jensimmons CreditAttribution: jensimmons commented

Yeah, that was my thinking — the odds are that the logo will not look good on white. It will only work if 1) the logo has no background of it's own (it's a png like the Druplicon logo), or 2) the header of the themed website is white (which is rare). I figured it would be better to simply not show the logo.

We can debate what to do about the logo — but meanwhile, we should commit this patch. It fixes a more serious bug, and puts Bartik back to the way it was before we colorized the header.

eigentor’s picture

eigentor CreditAttribution: eigentor commented

Jen is right - let's commit that and think about a potential logo later. +1 for RTBC.

jensimmons’s picture

jensimmons CreditAttribution: jensimmons commented
Priority: Normal » Major

This might actually be critical, but I hesitate to add another issue to the critical queue.

It is however, definitely RTBC! Please do commit, our fearless leaders.

int’s picture

int CreditAttribution: int commented
Priority: Major » Normal

How this can be critical? it's destroy user data?

And this don't remove any feature, and is only shows wrong in the maintenance page. So set normal.

jensimmons’s picture

jensimmons CreditAttribution: jensimmons commented

This bug means the maintainance page prints the site name in white, on a white background. So it doesn't show up. To me, that's a pretty big bug.

Mostly, though, this is DONE and RTBC!! Let's just commit it, rather than debating the rank! I don't know what the hesitation is.

int’s picture

int CreditAttribution: int commented
Status: Reviewed & tested by the community » Fixed

Commit #398428 by Dries at 16:50

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.