I got a report of:

-no visual indication of current keyboard focus on links in #toolbar in
IE8 and below: suggest using :active in addition to :hover and :focus
pseudo-classes to help sighted keyboard users in IE.

I've got a patch. But need Windows user to confirm/deny.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mgifford’s picture

Issue tags: +Accessibility

tagging

jasonkiss’s picture

I think the :active pseudo-class also needs to be added to the CSS block immediately above the one that the patch currently modifies, i.e., also change

#toolbar div.toolbar-menu ul li a:focus, 
#toolbar div.toolbar-menu ul li a:hover, 
#toolbar div.toolbar-menu ul li a.active:focus {
background:none repeat scroll 0 0 #444444;
}

to

#toolbar div.toolbar-menu ul li a:focus, 
#toolbar div.toolbar-menu ul li a:hover, 
#toolbar div.toolbar-menu ul li a:active, 
#toolbar div.toolbar-menu ul li a.active:focus {
background:none repeat scroll 0 0 #444444;
}

Additionally, I believe that #toolbar div.toolbar-menu ul li a.active:focus can also be removed since it is applied and overwritten by the CSS block that follows and which this patch currently modifies.

mgifford’s picture

FileSize
811 bytes

Thanks Jason. I've rolled this into a patch. Also wanted to thank you for reporting this issue to me and providing initial direction to add the focus/hover links in the css. Makes it so much easier!

jasonkiss’s picture

My pleasure :) Seems to be working fine now as links in the toolbar show the hover effect when receiving keyboard focus in IE.

Everett Zufelt’s picture

Priority: Normal » Critical

Setting to Critical as it prevents certain users from being able to use the toolbar. Luckily it's an easy fix. Thanks Mike and Jason.

Bojhan’s picture

Status: Needs review » Reviewed & tested by the community

Looks good.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Awesome, thanks! Committed to HEAD!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

sun’s picture

Status: Closed (fixed) » Fixed

I'm a bit confused here. While :active might have been good to add, too, the actual cause for the accessibility issue should be the override/reset/removal of 'outline', no?

casey’s picture

I think removing any outline style shouldn't be any problem as long as you provide an alternative. Like in case of the toolbar different background-colors.

mgifford’s picture

I think it's fine now, but perhaps I'm missing something. I saw an improvement with this patch in keyboard navigation.

Status: Fixed » Closed (fixed)
Issue tags: -Accessibility

Automatically closed -- issue fixed for 2 weeks with no activity.