Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I got a report of:
-no visual indication of current keyboard focus on links in #toolbar in
IE8 and below: suggest using :active in addition to :hover and :focus
pseudo-classes to help sighted keyboard users in IE.
I've got a patch. But need Windows user to confirm/deny.
Comment | File | Size | Author |
---|---|---|---|
#3 | toolbar_css-active-2.patch | 811 bytes | mgifford |
toolbar_css-active-1.patch | 1.07 KB | mgifford | |
Comments
Comment #1
mgiffordtagging
Comment #2
jasonkiss CreditAttribution: jasonkiss commentedI think the :active pseudo-class also needs to be added to the CSS block immediately above the one that the patch currently modifies, i.e., also change
to
Additionally, I believe that
#toolbar div.toolbar-menu ul li a.active:focus
can also be removed since it is applied and overwritten by the CSS block that follows and which this patch currently modifies.Comment #3
mgiffordThanks Jason. I've rolled this into a patch. Also wanted to thank you for reporting this issue to me and providing initial direction to add the focus/hover links in the css. Makes it so much easier!
Comment #4
jasonkiss CreditAttribution: jasonkiss commentedMy pleasure :) Seems to be working fine now as links in the toolbar show the hover effect when receiving keyboard focus in IE.
Comment #5
Everett Zufelt CreditAttribution: Everett Zufelt commentedSetting to Critical as it prevents certain users from being able to use the toolbar. Luckily it's an easy fix. Thanks Mike and Jason.
Comment #6
Bojhan CreditAttribution: Bojhan commentedLooks good.
Comment #7
webchickAwesome, thanks! Committed to HEAD!
Comment #9
sunI'm a bit confused here. While :active might have been good to add, too, the actual cause for the accessibility issue should be the override/reset/removal of 'outline', no?
Comment #10
casey CreditAttribution: casey commentedI think removing any outline style shouldn't be any problem as long as you provide an alternative. Like in case of the toolbar different background-colors.
Comment #11
mgiffordI think it's fine now, but perhaps I'm missing something. I saw an improvement with this patch in keyboard navigation.