omega_starterkit_render_attributes missing 'return' [#849092]

In the starterkit theme's template.php is this function:

function omega_starterkit_render_attributes($attributes) {
  // not sure why this has to be here anymore, investigating
	omega_render_attributes($attributes);
  
}

There needs to be a return before omega..., as in return omega_render_attributes($attributes);, for this to work, otherwise (currently) there are no attributes in subthemes' node templates.

Patch attached.

I'm not sure why the function is needed, either (as noted there), I would have thought theme() would pick up the parent theme's function, but it doesn't seem to work, so this is necessary instead.

Comment	File	Size	Author
	render-attributes.patch	493 bytes	thebuckst0p

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

himerus CreditAttribution: himerus commented 9 July 2010 at 14:28

Assigned:	Unassigned	» himerus
Status:	Needs review	» Fixed

Great catch! And thanks for the patch!

For anyone that runs across this issue, the patch has been committed to the starterkit, and any new subthemes created will work appropriately, however, subthemes that you have created will need a fix in your template.php in order to take this change.

/**
 * Create a string of attributes form a provided array.
 * 
 * @param $attributes
 * @return string
 */
function YOUR_THEME_NAME_render_attributes($attributes) {
	return omega_render_attributes($attributes);
}

You will need to add return before the call to omega_render_attributes in your subtheme's render_attributes function.

This is committed and will be in the next tagged release (6.x-1.0-beta8)