Hi there,

I was working with this module yesterday and had to override countdown.tpl.php to get more styling power for the counter. However, I found it broke due to that. I'm filing a patch that is a bit more forgiving and appears to work. It's not perfect...but it did the job for me.

There's some commented-out code in here since I didn't want to remove it entirely, but easy enough to remove of course.

Basically, I use the selection power of jQuery to look for in ANY descendent elements and put them into objEM. Of course, this'll break pretty easily if any more are added in the .tpl.php, but people could just use classes and some CSS to get the effect anyway, so I think it's a minor issue. It's less fragile than the original implementation, at least.

Another thing is that the part that looks for the text node never actually finds it, I don't think, so I think this may break the counting up functionality. Rather than using find('*'), I should probably use text(), or a text() inside of the find('*').each() - but I didn't need to go that far.

So take this patch for what it's worth...figured it was better to contribute back :)

Kevin

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

UsingSession’s picture

Issue summary: View changes
Status: Active » Closed (outdated)