When upgrading from 6.x to 7.x, webform_update_6314() fails with "Call to undefined function webform_date_string()". At the beginning of the update, webform_component_include('date') is called, which in turn calls webform_components(), which in turn uses module_implements() to get a list of components, which fails because webform is disabled. The webform_component_include() calls should be changed to module_load_include() as should the similar call for time.inc.

The attached patch does this, but it also has to leave in the drupal_load() of webform.module because time.inc does a webform_component_include('date') which fails if you don't load webform.module first. Alternatively you could change that to a module_load_include() as well theoretically, not sure how you feel about that.

CommentFileSizeAuthor
#1 842000.patch911 bytesgdd
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

gdd’s picture

Status: Active » Needs review
FileSize
911 bytes
quicksketch’s picture

Version: 7.x-3.x-dev » 6.x-3.0-beta6
Status: Needs review » Fixed

Thanks, committed to the DRUPAL-6--3 branch. The Drupal 7 branch doesn't have any updates in it yet.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.