Document form_options_flatten() [#838324]

Comment	File	Size	Author
#4	838324-form-doc.patch	1.65 KB	agentrickard

#3	838324-form-doc.patch	1.65 KB	agentrickard

#1	838324-form-doc.patch	1.46 KB	agentrickard

Comment #1

agentrickard

he/him

English

Georgia (US)

CreditAttribution: agentrickard commented 26 June 2010 at 16:53

Status:

Active

» Needs review

File	Size
838324-form-doc.patch	1.46 KB

And a patch, which also cleans up a verb tense in a nearby function.

Log in or register to post comments

Comment #2

aspilicious CreditAttribution: aspilicious commented 26 June 2010 at 16:57

+++ includes/form.inc	26 Jun 2010 16:49:20 -0000
@@ -2042,12 +2042,29 @@ function _form_set_value(&$form_values, 
+ * @param $array
+ *   The form options array to process.
+ * @return
+ *   An array with all hierarchical elements flattened to a single array.

Newline needed between @param and @return

+++ includes/form.inc	26 Jun 2010 16:49:20 -0000
@@ -2042,12 +2042,29 @@ function _form_set_value(&$form_values, 
+ */ ¶

trailing whitespace

+++ includes/form.inc	26 Jun 2010 16:49:20 -0000
@@ -2042,12 +2042,29 @@ function _form_set_value(&$form_values, 
+ * We iterate over multi-key arrays and return a flattened array with
+ * a single key, appropriate for use in HTML select forms.
+ */

You return something why don't we have an @return statement?

46 critical left. Go review some!