We can now remove mappings in tests. Also in both removeMappings() and addMappings() we are checking the feeds_importer configs to be sure the mappings were added.


alex_b’s picture

Status:Needs review» Fixed

I get 4 fails for "RSS import to data records":

All on 'mapping exists after addition'.

Using HEAD of http://drupal.org/project/issues/feeds_test.

andrewlevine’s picture

Assigned:Unassigned» andrewlevine
Status:Fixed» Needs work

Did you mean to mark this fixed?

It looks like this is because FeedsDataProcessor overrides addMapping and modifies the target field. I'm going to add an optional $test_mappings paramater to addMappings() and removeMappings() so FeedsRSStoDataTest can avoid testing mappings (because it does it itself in the test anyway).

Sound good?

alex_b’s picture

Sounds good.

andrewlevine’s picture

Assigned:andrewlevine» Unassigned
Status:Needs work» Needs review
new5.05 KB

Attached is the patch with the mentioned changes. All tests pass except for in Filefield (but this is something unrelated to this patch on my machine)

twistor’s picture

Version:6.x-1.x-dev» 7.x-2.x-dev
Assigned:Unassigned» twistor
Status:Needs review» Needs work

This is a nice bit of kit. Will add to 7.x first, then backport.

twistor’s picture

new4.61 KB

Here's an initial port.

twistor’s picture

new4.77 KB

I like returning -1 better actually.

twistor’s picture

Status:Needs work» Patch (to be ported)

Committed a modified version to 7.x