Wrong Advice to Revert to the Default Shipping Rate per Product [#834676]

When the flatrate module is enabled and a default shipping flat rate is entered, you can override this value on a per product basis. To revert to the default shipping rate the text in the box "Flat shipping rates" says:
"Override the default shipping rate per product for each flat rate shipping method here. Enter -1 to revert to the default value."
This is wrong. After entering -1 there will be a shipping rate of -1.0000 € (or whatever currency you use). Thus the flat shipping rate for an order will be deducted by this 1 € if that product is in the shopping cart.

The correct handling is to clear this field when you save the product. An the text should read something like this:

"Override the default shipping rate per product for each flat rate shipping method here. Remove this value to revert to the default value."

Comment	File	Size	Author
#1	834676_uc_flatrate_wrong_default_advice.patch	1.01 KB	GuyPaddock
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

GuyPaddock CreditAttribution: GuyPaddock commented 8 July 2010 at 22:36

Status:

Active

» Needs review

File	Size
834676_uc_flatrate_wrong_default_advice.patch	1.01 KB

Attached is a patch to fix the verbiage in this section. The text change will need to be translated.

Comment #2

saccard CreditAttribution: saccard commented 16 July 2010 at 15:51

Thanks!

Here a suggestion for the german text:
"Hier können die Standard-Versandkosten pro Artikel (für alle pauschalen Versandkosten) überschrieben werden. Feld leer lassen, um den Standardwert zu verwenden."

Comment #3

TR CreditAttribution: TR commented 14 February 2011 at 07:06

Status:

Needs review

» Fixed

Fixed in 6.x-2.x-dev and 7.x-3.x-dev.

Comment #4

TR CreditAttribution: TR commented 14 February 2011 at 07:06

Version:

6.x-2.2

» 7.x-3.x-dev

Comment #5

SeanA CreditAttribution: SeanA commented 20 February 2011 at 03:06

Status:

Fixed

» Active

The same text needs to be changed in uc_weightquote.

There's also this bug. Does it make sense to allow negative shipping rates? Suggestion for uc_flatrate and uc_weightquote:

- if ($rate !== '') {
+ if ($rate !== '' && $rate > 0) {

Comment #6

TR CreditAttribution: TR commented 20 February 2011 at 03:57

OK. Fixed the text for uc_weightquote as well in both the 6.x and 7.x branches.

Rate probably shouldn't be negative, but doesn't have to be > 0! Also, $rate !== '' seems like a bad idea to me - what if someone has a space in that field, that would be "invisible" but would not override the default rate. Very hard to track down a problem like that. Probably should check if $rate is numeric and non-negative instead.

Comment #7

SeanA CreditAttribution: SeanA commented 20 February 2011 at 16:45

Right, I see now... if the default is 5.00, you might want to override that and set it to zero for certain items. Currently, if you enter a space (or other non-numeric characters) in the field, it becomes 0.00000 and so it will override (and will show up as 0.00000 in the field).

if ($rate !== '' && $rate >= 0) { // contains something and is a non-negative number