Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
RTBC, lots of column definition changes.
Original issue:
#690746: Text column type doesn't reliably hold serialized variables
Comment | File | Size | Author |
---|---|---|---|
#6 | 690746_serialized_fields_to_blobs.patch | 2.02 KB | JacobSingh |
#3 | 690746_serialized_fields_to_blobs.patch | 1.88 KB | JacobSingh |
Comments
Comment #1
catchNow committed.
Comment #2
Gábor HojtsyModules which were changed and how we need to treat them:
DONE
- user: got user_update_7009() so no need to act there
- database_test: don't think we should deal with this, its a test module
- filter: covers the filter table and the cache_filter table even
- dblog: got its update
TODO
- update: got its cache_update table changed http://drupalcode.org/viewvc/drupal/drupal/modules/update/update.install...
- system: got its various table updated with system_update_7055(), but no updates for cache tables
- rdf: new module in D7, so no update function
- image: same stuff
- field: blah
- block: cache_block changed, old update function modified, so we need to work here: http://drupalcode.org/viewvc/drupal/drupal/modules/block/block.install?r...
Comment #3
JacobSingh CreditAttribution: JacobSingh commentedThis patch tries to solve it by just going through every field in a table created by core and if it is serialized == TRUE, making it a blob.
Is this the correct logic? It seems to work fine.
Comment #4
Gábor HojtsyLooks good to me but I did not test it.
Comment #5
JacobSingh CreditAttribution: JacobSingh commentedDamZ: JacobSingh: the logic seems ok... that said, the schema is already updated so you don't need the $field['type'] = 'blob';
[3:17pm] DamZ:
[3:18pm] DamZ: JacobSingh: so I would restrict that to columns that are already 'blob' in the schema in the first place
[3:18pm] stewsnooze joined the chat room.
[3:18pm] JacobSingh: DamZ: oh right...
[3:19pm] chx: DamZ: http://drupal4hu.com/node/260
[3:19pm] JacobSingh: DamZ: would that be true if an update was attempted without a cache clear?
[3:19pm] JacobSingh: DamZ: as in, if you updated the code, and then ran update.php, could the old schema still be cached?
[3:19pm] DamZ: JacobSingh: the schema is cached, but I think we regenerate it at the start of the update process
[3:19pm] JacobSingh: DamZ: okay, anyway this is a pretty old head2head
[3:19pm] JacobSingh: so I imagine anyone running it has had the new code around for awhile
Comment #6
JacobSingh CreditAttribution: JacobSingh commentedComment #7
JacobSingh CreditAttribution: JacobSingh commentedDamZ RTBC'd this in chat.
committed