Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ipwa’s picture

FileSize
985 bytes

Patch applying the same style as sidebar blocks to the highlight region.

Here is a screenshot of how it looks: http://skitch.com/ipwa/dkdn3/test-localhost

The whole region is styled with the border, do you guys think it should be each individual block instead?

jensimmons’s picture

Status: Active » Needs work

patch failed

ipwa’s picture

I'll checkout Bartik head again and re-roll the patch, it would be nice to have the patch test bot on the Bartik queue.

jensimmons’s picture

Title: Content in Highlight and Help regions doesn't look to hot » Content in Bartik Highlight and Help regions doesn't look to hot
Project: Bartik » Drupal core
Version: 7.x-1.x-dev » 7.x-dev
Component: Look and Feel » Bartik theme

Embedding above screenshot of the problem for easier viewing:

Jeff Burnz’s picture

Status: Needs work » Needs review

sick the bot on it, see if we need a re-roll, looks good though, nice and simple.

Status: Needs review » Needs work

The last submitted patch, bartik-highlight.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
FileSize
1007 bytes

Needed reroll.

jensimmons’s picture

Priority: Normal » Major
Status: Needs review » Needs work
Issue tags: +jen's hit list

Screenshot from comment #1 with the original solution.
a screenshot showing the visual styling of the highlighted region

I'm going to look at this as soon as I can, and work on the design a bit.

Meanwhile, I'm bumping this to major. It's not major for Drupal in general — but looking at the list of Bartik bugs that are left, it's one of the more major ones. The Bartik teams needs to easily see what is the highest priority for us. I say this one is in the top 5 of what's left.

eugene.samoylenko’s picture

I'm kinda newbie to Drupal and it's my very first experience of creating patches, so please don't be angry if I did something wrong :-)

I just added a little "hotness" to blocks' style.
Files highlighted-bg.png and help-bg.png should be put into /bartik/images/ directory.
File bartik-highlighted-help.png shows how it should look like after applying the patch (I hope it won't fail).

eugene.samoylenko’s picture

Status: Needs work » Needs review

Please review :-)

Jeff Burnz’s picture

@#9/#10 - its too late for us to be introducing new design into core, especially for the actual help block.

@#7 - isn't the OP for highlighted and help, the patch only seems to cover highlighted? Whats the plan for blocks in help?

tim.plunkett’s picture

BenK’s picture

Subscribing

bleen’s picture

@eugene.samoylenko ... Jeff is correct that it is too late in the process to make any drastic design changes, but don't get discouraged - there are plenty of issues that need themers to pitch in on and you nailed the process on your first patch :)

jensimmons’s picture

FileSize
733 bytes

Alrighty. I'm proposing these simple changes — they fix the bug that exists now: namely when you use the help or highlighted regions, they don't do much visually. In fact right now, they are identical to each other.

Highlighted BEFORE:
a screenshot of how the highlight region looks with a simple block of text

Highlighted AFTER:
a screenshot of how the highlight region looks with a simple block of text after the patch is applied

Help BEFORE:
a screenshot of how the help region looks with a simple block of text

Help AFTER:
a screenshot of how the help region looks with a simple block of text after the patch is applied

jensimmons’s picture

FileSize
740 bytes

There may be something wrong with that patch — Tim was having a hard time applying it. So here's a reroll.

tim.plunkett’s picture

Status: Needs review » Reviewed & tested by the community

Code looks good, the result looks even better. I really like the 120% on the #highlighted.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

The Help region's styling is pushing it for what's acceptable post-RC. However, without something there, I agree that this is terribly weird + confusing.

So, committed to HEAD. Thanks!

Status: Fixed » Closed (fixed)
Issue tags: -jen's hit list

Automatically closed -- issue fixed for 2 weeks with no activity.