Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
At the moment it's totally un-styled. See screenshot.
Comment | File | Size | Author |
---|---|---|---|
#16 | bartik-827530-16.patch | 740 bytes | jensimmons |
#15 | bartik-827530-15.patch | 733 bytes | jensimmons |
#12 | drupal-bartik-827530-12.patch | 995 bytes | tim.plunkett |
#9 | bartik-highlighted-help.patch | 917 bytes | eugene.samoylenko |
#9 | bartik-highlighted-help.png | 85.73 KB | eugene.samoylenko |
Comments
Comment #1
ipwa CreditAttribution: ipwa commentedPatch applying the same style as sidebar blocks to the highlight region.
Here is a screenshot of how it looks: http://skitch.com/ipwa/dkdn3/test-localhost
The whole region is styled with the border, do you guys think it should be each individual block instead?
Comment #2
jensimmons CreditAttribution: jensimmons commentedpatch failed
Comment #3
ipwa CreditAttribution: ipwa commentedI'll checkout Bartik head again and re-roll the patch, it would be nice to have the patch test bot on the Bartik queue.
Comment #4
jensimmons CreditAttribution: jensimmons commentedEmbedding above screenshot of the problem for easier viewing:
Comment #5
Jeff Burnz CreditAttribution: Jeff Burnz commentedsick the bot on it, see if we need a re-roll, looks good though, nice and simple.
Comment #7
tim.plunkettNeeded reroll.
Comment #8
jensimmons CreditAttribution: jensimmons commentedScreenshot from comment #1 with the original solution.
I'm going to look at this as soon as I can, and work on the design a bit.
Meanwhile, I'm bumping this to major. It's not major for Drupal in general — but looking at the list of Bartik bugs that are left, it's one of the more major ones. The Bartik teams needs to easily see what is the highest priority for us. I say this one is in the top 5 of what's left.
Comment #9
eugene.samoylenko CreditAttribution: eugene.samoylenko commentedI'm kinda newbie to Drupal and it's my very first experience of creating patches, so please don't be angry if I did something wrong :-)
I just added a little "hotness" to blocks' style.
Files highlighted-bg.png and help-bg.png should be put into /bartik/images/ directory.
File bartik-highlighted-help.png shows how it should look like after applying the patch (I hope it won't fail).
Comment #10
eugene.samoylenko CreditAttribution: eugene.samoylenko commentedPlease review :-)
Comment #11
Jeff Burnz CreditAttribution: Jeff Burnz commented@#9/#10 - its too late for us to be introducing new design into core, especially for the actual help block.
@#7 - isn't the OP for highlighted and help, the patch only seems to cover highlighted? Whats the plan for blocks in help?
Comment #12
tim.plunkettReroll due to #862854: No styling for sticky.
Comment #13
BenK CreditAttribution: BenK commentedSubscribing
Comment #14
bleen CreditAttribution: bleen commented@eugene.samoylenko ... Jeff is correct that it is too late in the process to make any drastic design changes, but don't get discouraged - there are plenty of issues that need themers to pitch in on and you nailed the process on your first patch :)
Comment #15
jensimmons CreditAttribution: jensimmons commentedAlrighty. I'm proposing these simple changes — they fix the bug that exists now: namely when you use the help or highlighted regions, they don't do much visually. In fact right now, they are identical to each other.
Highlighted BEFORE:
Highlighted AFTER:
Help BEFORE:
Help AFTER:
Comment #16
jensimmons CreditAttribution: jensimmons commentedThere may be something wrong with that patch — Tim was having a hard time applying it. So here's a reroll.
Comment #17
tim.plunkettCode looks good, the result looks even better. I really like the 120% on the #highlighted.
Comment #18
webchickThe Help region's styling is pushing it for what's acceptable post-RC. However, without something there, I agree that this is terribly weird + confusing.
So, committed to HEAD. Thanks!