Was thinking of another suggestion for the module.

At the moment, to navigate photo to photo, we use the thumbnail gallery below.

Would it also be possible that if we clicked on the slide itself that it could forward to the next photo?

And if that is possible, then when in javascript enabled situations can the icon link to the colorbox coexist?

I was thinking about this because of how facebook has likely conditioned people.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Manuel Garcia’s picture

Status: Active » Closed (duplicate)

This is being discussed in this issue: #810302: Add slideshow-type feature, marking as duplicate.

Trunkhorn’s picture

This issue struck me as a slightly different take since slideshows require javascript functionality? I was seeing this as maybe a default possibilty for javascript disabled behavior?

Manuel Garcia’s picture

Well, the gallery works without JS enabled using the thumbnails, wich is more than most galleries provide... plus, we are using the slides to link to the full img, for usability reasons (see #800244: Make the whole picture clickable for "big size view").
I understand that well, maybe some people would expect that functionality, but I bet more people would expect to click on the image to see the big image. So the slideshow will eventualy be implemented like we discuss in the other issue, you're welcome to participate there and ensure it's a usable solution, we still have to think about how to do it properly.

Trunkhorn’s picture

Well I checked out that discussion and wish I had been checking in on this module earlier.

I like the current small slide format with its carousel, but hope to see another way for a user to advance forward by clicking.

There are competing issues there, in that in the current formulation, a user will intentionally click on a photo that interests them, but in a forward advance through an entire gallery, people might look at more photos. A site might not want to serve up so many photos, but of course the javascript boxes (colorbox) does it that way only.

On the other hand, the way galleryformatter handles titles and descriptions on the same image is very nice, so having fofrward and back controls image to image would be nice.

Pardon my rambling!

glennr’s picture

+1 on this request for at least an option for the main image to forward to next one when the user clicks on it. Personally, I think this would improve usability, as in many cases, the main image is big enough.

The similar Galleria module has this by default, but also supports Lightbox if you want the option of clicking through to a larger image. However, I would prefer to use Galllery Formatter as, overall, I think it's a superior module. Thanks for sharing it with us.

Manuel Garcia’s picture

Title: Simple photo advance? » Add simple photo advance
Status: Closed (duplicate) » Active

I think if we make this a new feature, it will be this way:

  1. Using forward and back icons on overlaying on the slide image.
  2. Having those buttons make the thumbnail carousel skip to the next page if necessary.
  3. Having those buttons highlight the corresponding image on the thumbnails.

So, as you see this is not an easy task. I accept patches that take this directions, so I'm setting this as active. Once we have the require functions we can then perhaps add #810302: Add slideshow-type feature

Manuel Garcia’s picture

Status: Active » Needs review
FileSize
5.47 KB
492 bytes

OK, I had some time today, and had a go at this request.

I attach a patch and an image that should probably be worked on a bit more to be in line with the current included sytle, and added to the sprite. For now it is just a placeholder. This image should be placed under gallerystyles/greenarrows/images/

The patch is a fairly complex one, because of the way that infinite carousel works, and adds quite some code to our JS. I understand that this is a nice feature to have, but we should really do this right, if anyone of you is handy with jQuery/JS, or know anyone that is, please review this properly and let's try to make it as light as possible.

Manuel Garcia’s picture

Updated patch, changes:

  1. It now properly works with several galleries on the same page.
  2. It now uses a public interface so that we can trigger the custom events remotely for next and previous slides

Please test in different browsers if you can.

Trunkhorn’s picture

Very cool Manuel! I will be able to test this in a few hours and get back to you!

Trunkhorn’s picture

This works perfectly in Firefox! I really like seeing this step... very stylish. I don't have IE on anything so I can't test that unfortunately.

BenK’s picture

Subscribing...

Manuel Garcia’s picture

Thanks Trunkhorn... although ff is the only browser I tested in also (actualy, where I developed it). Anyone able to test on IE / Chrome / Opera etc?

jonhattan’s picture

Status: Needs review » Reviewed & tested by the community

Tested with success in chrome, ie7, ie8, opera and safari. /me going to wash his hands :)

jonhattan’s picture

I think it is buggy if nostyle.

See attached screenshot, on the left upper corner. It seems < > plus a <li>-bullet.

Left and right 'arrows' < > are not clickable.

seen on firefox and chrome. not tested in other browsers.

Manuel Garcia’s picture

Awesome! Thanks a lot jonhattan =)

Now the question is... should we make this an optional feature or just go ahead and run with it?

Manuel Garcia’s picture

Status: Reviewed & tested by the community » Needs work

Oops, crossposted

jonhattan’s picture

I think it should be optional along with the other arrows for thumbnails. Perhaps a select box with options: arrows in slide | arrows in thumbnails | arrows for both

Manuel Garcia’s picture

OK, here's another go at it.

I've fixed the problem with the no-style layout, which made me discover a minor bug, basically we were adding the galleryfromatter-view-full class to both the overall wrapper as well as the link itself, thus we couldn't target the link independently.

OK so that's out of the way. Now, I've discovered that the auto-paging when you click next, and the next image is not in the same carousel page, it doesn't switch to the next page. It does however on the next one, so I'll have to troubleshoot that before we are ready to commit. Or if anyone feels like having some fun, please do work on this =)

Here's the updated patch.

Manuel Garcia’s picture

Apparently this new bug is introduced in the new patch somehow, in the previous one on #8 it's not there, yay. Probably something to do with positioning...

Manuel Garcia’s picture

OK, here's the updated patch, it now works properly. Keep in mind that no-style is for developing new styles only, obviously you should never use it in production...

As far as making this optional, OK, we can have a go at it.

And for making the arrows on the thumbnails optional, this means basically making the infinite carousel optional, which introduces the question as to how to then displays the thumbnails... i assume in a grid below. This means assigning another class to the wrapper so we can change the CSS for the thumbnails etc. We should work on this on another feature request.

Manuel Garcia’s picture

I'm messy today... sorry, this is the good one, without leftover console.log calls...

Anonymous’s picture

Applied patch and seems to work perfectly. Thanks!

ed. I notice strange behaviours when browsing the images with the slide buttons: The pages of images in the bar below change one image late - I don't know how to explain that really.

How much images should be displayed in the image bar and which style definitions _need_ to be in place for the pager to behave correctly? I use "no-style" and customised elements to my needs (for example, the buttons to browse pages are overlayed on the images in the image bar and the image bar is the same width as the big image above). Would be great to have some sort of a theming guideline or mentions of possible pitfalls with the paging mechanism. For now I just tweaked the image widths until it works but I don't really know where or what the problem is..

Is it recommended to use the default dimensions for large and small images and not change positioning of arrows at all? I'm a bit lost here. :-)

Manuel Garcia’s picture

Status: Needs work » Needs review
Trunkhorn’s picture

That would be cool to have into dev and stable. I've been using my patched by hand version for 2 months now, and am worried I've missed whatever updates you've had since I've done it.

Manuel Garcia’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Needs review » Fixed

Just a little heads up guys, this feature has gone into the 7.x branch:
http://drupal.org/cvs?commit=491902
http://drupal.org/cvs?commit=491904

I don't have much free time so I doubt this feature will go in for d6... the last patch had to be touched a bit before commiting, mainly the line in galleryformatter.js:
var $nextThumbLi = $thumbsLi.filter('.active').nextAll().not('.cloned, .empty, .active').filter(':first');
Before it was not filtering out .active items, so it wasnt working properly on next image, only on very first load, without having triggered any other events on the gallery. Very weird bug but well, there you go.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.