There is a hard code static names in sql table names. So if we use db_prefix for table name, we get error.
Could it be with {} instead?
Have a nice time with aegir ;o)

CommentFileSizeAuthor
#3 table_name_with_brackets-2.patch899 bytespokurek
table_name_with_brackets.patch4.45 KBpokurek
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pokurek’s picture

pokurek CreditAttribution: pokurek commented
Project: Hostmaster (Aegir) » Hosting

Moving this issue to the better project.

adrian’s picture

adrian CreditAttribution: adrian commented
Status: Active » Needs work

the current and target tables are temporary and are meant to be that way. they exist only for the session and shouldnt be modified.

additionally. it is highly highly highly recommended that you do NOT try to run aegir with db prefixing.
We will not be maintaining an upgrade path for this.

The curly brackets around the hosting_package tables are relevant though, and i will commit that change if you re-roll the patch.

pokurek’s picture

pokurek CreditAttribution: pokurek commented
FileSize
table_name_with_brackets-2.patch899 bytes

Sorry, but I am not sure What You mean with re-roll the patch :o(

So I thing that brackets are important only in this case:

function _hosting_package_temporary_table($name, $ref) {
  db_query("CREATE TEMPORARY TABLE %s AS SELECT nid, short_name, old_short_name, version_code, schema_version, version, status from {hosting_package} p left join {hosting_package_instance} i on p.nid = i.package_id where rid= %d", $name, $ref);
}
adrian’s picture

adrian CreditAttribution: adrian commented
Status: Needs work » Fixed

committed to HEAD.
thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 49df7f1 on 6.x-2.x, 7.x-3.x, dev-ssl-ip-allocation-refactor, dev-sni, dev-helmo-3.x by adrian: 
    Escape table names. thanks pokurek. : #823360

  • Commit 49df7f1 on 6.x-2.x, 7.x-3.x, dev-ssl-ip-allocation-refactor, dev-sni, dev-helmo-3.x by adrian: 
    Escape table names. thanks pokurek. : #823360