Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Hierarchical Select Taxonomy module adds some settings to Vocabulary settings page. Also it adds Preview section. Preview is very useful feature when vocabulary is being configured to use HS. But for Tags vocabularies it loads the whole list and this leads to PHP fatal error
Fatal error: Maximum execution time of 30 seconds exceeded in ...
To avoid this I created small patch that checks if the vocabulary we are editing is Tags and does not display Preview section for it.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | hs-tags-disable.patch | 3.3 KB | vgarvardt |
| hs-tags-disable-preview.patch | 4.92 KB | vgarvardt | |
Comments
Comment #1
Wim LeersExcellent assessment. Not sure why nobody brought this up sooner :) Of course, I wholeheartedly agree :)
However, I don't agree with your patch. It disables the preview, which is good. But it's not enough. It doesn't make sense to enable HS for tag vocabularies in the first place. So I think we should only add the HS config form to the vocabulary form when the vocabulary is NOT a tag vocabulary. And there should be a message saying something like "HS can only be enabled for non-tag vocabularies".
What do you think? :)
Comment #2
vgarvardt CreditAttribution: vgarvardt commentedI agree.
I needed quick fix for the HS when I posted this patch.
I will create new patch that will implement your idea - disable HS completely for Tags vocabularies.
Comment #3
vgarvardt CreditAttribution: vgarvardt commentedHere is new patch version, that does not display HS settings for Tags vocabularies.
Comment #4
Wim LeersGreat work, thanks! :) Committed: http://drupal.org/cvs?commit=412232.
I did not backport this to D6 though. It'd be great if you wanted to contribute that too, if not, this will only be fixed in D6.
Comment #5
Wim LeersGreat work, thanks! :) Committed: http://drupal.org/cvs?commit=412232.
I did not backport this to D6 though. It'd be great if you wanted to contribute that too, if not, this will only be fixed in D6.
Comment #6
vgarvardt CreditAttribution: vgarvardt commentedBackport to D5 you mean?
Comment #7
Wim LeersOkay that was stupid of me. Of course, backport to D5, since this obviously was a patch to D6. My bad!