If you try get page like http://localhost/profile/profile_name and "profile_name" field not exist, you will get php warnings showed to users.

Notice: Trying to get property of non-object in profile_browse() (line 18 of /var/www/drupal/modules/profile/profile.pages.inc).
Notice: Trying to get property of non-object in profile_browse() (line 89 of /var/www/drupal/modules/profile/profile.pages.inc).

it's a bit confusing to users.
apache2 + php(5.3.2-1ubuntu4.2). Drupal7 from cvs.

CommentFileSizeAuthor
#5 reroll_patch-818988-5.patch1.16 KBmoshnoi
#2 818988_profile_fix_warning.patch1.09 KBcross
#1 818988_profile_fix_warning.patch1.09 KBcross
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cross’s picture

cross CreditAttribution: cross commented
FileSize
818988_profile_fix_warning.patch1.09 KB

There is small patch to fix it.

cross’s picture

cross CreditAttribution: cross commented
FileSize
818988_profile_fix_warning.patch1.09 KB

forgot --no-prefix to git diff. There is fixed patch.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Active » Needs review

Setting status to needs review so that the patch is tested.

thedavidmeister’s picture

thedavidmeister CreditAttribution: thedavidmeister commented
Issue summary: View changes
Status: Needs review » Needs work

This code doesn't exist in d8, so no need to bump the version.

Patch needs a re-roll:

tdm:d7 thedavidmeister$ git apply 818988_profile_fix_warning_0.patch 
error: profile/profile.pages.inc: No such file or directory

+ if (empty($field) && $name) {

Would the equivalent logic to what is being replaced not be empty($field->fid) rather than empty($field)?

moshnoi’s picture

moshnoi CreditAttribution: moshnoi commented
Status: Needs work » Needs review
FileSize
reroll_patch-818988-5.patch1.16 KB

Re-roll patch.