I am missing the save button, any tips on why?

CommentFileSizeAuthor
#2 ScreenShot088 copy.gif58.1 KBcalbert
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

berliner’s picture

Status: Active » Postponed (maintainer needs more info)

Can you give me some information on your environment? What Drupal-Version, what Modalframe version? What Browser? ... If you could attach a screenshot that would be maybe helpful as well.

calbert’s picture

FileSize
58.1 KB

Drupal 6.1.6

Modframe 6.x-1.x-dev

Browse: Firefox, and IE ( no save button on both )

I've attached screen shot.

berliner’s picture

Sure you are talking about Drupal 6.1.6? I couldn't find that release. I tested it with Modalframe 6.x-1.x-dev (jquery 1.3 + jquery_ui 1.7 as well as jquery 1.2.6 + jquery_ui 1.6) and couldn't reproduce the behaviour. Can you check in the generated source code of modalframe if the html for the save button is generated? Maybe it is simply hidden by some css rule?

Would there be any way that I can visit an online demo of your installation?

calbert’s picture

The site is set for ip access only, so being able to view it might be a problem. I've checked the generated code from your demo site to mine and there is no save button. It doesn't appear to be hidden just missing.

Drupal is 6.16 sorry for typo. I have yet to upgrade to 6.17

I'll paste in the code.

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en" dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<link rel="shortcut icon" href="/sites/all/themes/acquia_marina/favicon.ico" type="image/x-icon" />
<title>Create Sticky Note</title>
<link type="text/css" rel="stylesheet" media="all" href="/sites/all/modules/admin_menu/admin_menu.css?K" />
<link type="text/css" rel="stylesheet" media="all" href="/modules/book/book.css?K" />
<link type="text/css" rel="stylesheet" media="all" href="/modules/node/node.css?K" />
<link type="text/css" rel="stylesheet" media="all" href="/modules/system/defaults.css?K" />
<link type="text/css" rel="stylesheet" media="all" href="/modules/system/system.css?K" />
<link type="text/css" rel="stylesheet" media="all" href="/modules/system/system-menus.css?K" />
<link type="text/css" rel="stylesheet" media="all" href="/modules/user/user.css?K" />
<link type="text/css" rel="stylesheet" media="all" href="/sites/all/modules/cck/theme/content-module.css?K" />
<link type="text/css" rel="stylesheet" media="all" href="/sites/all/modules/jquerymenu/jquerymenu.css?K" />

<link type="text/css" rel="stylesheet" media="all" href="/sites/all/modules/nice_menus/nice_menus.css?K" />
<link type="text/css" rel="stylesheet" media="all" href="/sites/all/modules/nice_menus/nice_menus_default.css?K" />
<link type="text/css" rel="stylesheet" media="all" href="/modules/forum/forum.css?K" />
<link type="text/css" rel="stylesheet" media="all" href="/sites/all/modules/cck/modules/fieldgroup/fieldgroup.css?K" />
<link type="text/css" rel="stylesheet" media="all" href="/sites/all/modules/views/css/views.css?K" />
<link type="text/css" rel="stylesheet" media="all" href="/sites/all/modules/modalframe/css/modalframe.child.css?K" />
<link type="text/css" rel="stylesheet" media="all" href="/sites/all/themes/acquia_marina/style.css?K" />
<link type="text/css" rel="stylesheet" media="all" href="/sites/all/themes/acquia_marina/icons.css?K" />
<link type="text/css" rel="stylesheet" media="all" href="/sites/all/themes/acquia_marina/dblog.css?K" />
<link type="text/css" rel="stylesheet" media="all" href="/sites/all/themes/acquia_marina/theme_settings/fluid.css?K" />
<link type="text/css" rel="stylesheet" media="all" href="/sites/all/themes/acquia_marina/theme_settings/fonts_1.css?K" />
<script type="text/javascript" src="/sites/all/modules/jquery_update/replace/jquery.min.js?K"></script>
<script type="text/javascript" src="/misc/drupal.js?K"></script>
<script type="text/javascript" src="/modules/wysiwyg/wysiwyg.init.js?K"></script>

<script type="text/javascript" defer="defer" src="/sites/all/modules/admin_menu/admin_menu.js?K"></script>
<script type="text/javascript" src="/sites/all/modules/jquerymenu/jquerymenu.js?K"></script>
<script type="text/javascript" src="/sites/all/modules/nice_menus/superfish/js/superfish.js?K"></script>
<script type="text/javascript" src="/sites/all/modules/nice_menus/superfish/js/jquery.bgiframe.min.js?K"></script>
<script type="text/javascript" src="/sites/all/modules/nice_menus/superfish/js/jquery.hoverIntent.minified.js?K"></script>
<script type="text/javascript" src="/sites/all/modules/nice_menus/nice_menus.js?K"></script>
<script type="text/javascript" src="/sites/all/modules/jquery_ui/jquery.ui/ui/minified/ui.core.min.js?K"></script>
<script type="text/javascript" src="/sites/all/modules/modalframe/js/child.js?K"></script>
<script type="text/javascript" src="/misc/progress.js?K"></script>

<script type="text/javascript" src="/misc/textarea.js?K"></script>
<script type="text/javascript" src="/sites/all/libraries/ckeditor/ckeditor.js?K"></script>
<script type="text/javascript" src="/modules/wysiwyg/editors/js/ckeditor-3.0.js?K"></script>
<script type="text/javascript" src="/modules/wysiwyg/editors/js/none.js?K"></script>
<script type="text/javascript" src="/sites/all/modules/jquery_update/replace/jquery.form.js?K"></script>
<script type="text/javascript" src="/sites/all/modules/jquery_update/replace/ahah.js?K"></script>
<script type="text/javascript" src="/sites/all/themes/acquia_marina/script.js?K"></script>
<script type="text/javascript">
<!--//--><![CDATA[//><!--
jQuery.extend(Drupal.settings, { "basePath": "/", "admin_menu": { "margin_top": 1, "position_fixed": 1 }, "nice_menus_options": { "delay": 800, "speed": 1 }, "sticky_notes": { "current_pattern": "node", "current_path": "node", "original_scope": false }, "ahah": { "edit-book-bid": { "url": "/book/js/form", "event": "change", "keypress": null, "wrapper": "edit-book-plid-wrapper", "selector": "#edit-book-bid", "effect": "slide", "method": "replace", "progress": { "type": "throbber" }, "button": false }, "edit-attach": { "url": "/upload/js", "event": "mousedown", "keypress": true, "wrapper": "attach-wrapper", "selector": "#edit-attach", "effect": "none", "method": "replace", "progress": { "type": "bar", "message": "Please wait..." }, "button": { "attach": "Attach" } } }, "wysiwyg": { "configs": { "ckeditor": { "global": { "editorBasePath": "/sites/all/libraries/ckeditor", "execMode": "" }, "format1": { "baseHref": "https://metrosource.metrocast.com/", "width": "100%", "resize_minWidth": 450, "height": 420, "theme": "default", "skin": "v2", "entities_latin": false, "entities_greek": false, "format_tags": "p;address;pre;h2;h3;h4;h5;h6;div", "apply_source_formatting": 0, "contentsCss": [ "/sites/all/themes/acquia_marina/style.css", "/sites/all/themes/acquia_marina/icons.css", "/sites/all/themes/acquia_marina/dblog.css" ], "language": "en", "resize_enabled": 1, "toolbarLocation": "top" }, "format2": { "baseHref": "https://metrosource.metrocast.com/", "width": "100%", "resize_minWidth": 450, "height": 420, "theme": "default", "skin": "v2", "entities_latin": false, "entities_greek": false, "format_tags": "p;address;pre;h2;h3;h4;h5;h6;div", "apply_source_formatting": 0, "contentsCss": [ "/sites/all/themes/acquia_marina/style.css", "/sites/all/themes/acquia_marina/icons.css", "/sites/all/themes/acquia_marina/dblog.css" ], "language": "en", "resize_enabled": 1, "toolbarLocation": "top" } } }, "disable": "Disable rich-text", "enable": "Enable rich-text", "plugins": { "format1": { "native": [  ], "drupal": [  ] }, "format2": { "native": [  ], "drupal": [  ] } } } });
//--><!]]>
</script>
<script type="text/javascript">
<!--//--><![CDATA[//><!--
if (Drupal.jsEnabled) { $(document).ready(function() { $('#edit-book-pick-book').css('display', 'none'); }); }
//--><!]]>

</script>
</head>
<body>
<div class="modalframe-page-wrapper">
  <div class="modalframe-page-container clear-block">
    <div class="modalframe-page-content">
<div class="clear-block">
  <div id="sticky-notes-form"><form action="/sticky-notes/add?pattern=node&amp;path=node"  accept-charset="UTF-8" method="post" id="node-form" enctype="multipart/form-data">
<div><div class="body-field-wrapper"><div class="form-item" id="edit-body-wrapper">
 <label for="edit-body">Note: <span class="form-required" title="This field is required.">*</span></label>
 <textarea cols="20" rows="5" name="body" id="edit-body"  class="form-textarea required"></textarea>

</div>
</div><div id="edit-link_scope-wrapper"><div class="form-item">
 <label>Visibility: </label>
 <div class="form-radios"><div class="form-item" id="edit-link-scope-all-wrapper">
 <label class="option" for="edit-link-scope-all"><input type="radio" id="edit-link-scope-all" name="link_scope" value="all"   class="form-radio" /> On all pages</label>
</div>
<div class="form-item" id="edit-link-scope-path-wrapper">
 <label class="option" for="edit-link-scope-path"><input type="radio" id="edit-link-scope-path" name="link_scope" value="path"  checked="checked"  class="form-radio" /> Only on the current page</label>

</div>
</div>
</div>
</div><div class="form-item" id="edit-priority-wrapper">
 <label for="edit-priority">Priority: </label>
 <select name="priority" class="form-select" id="edit-priority" ><option value="0" selected="selected">Low</option><option value="1">Normal</option><option value="2">High</option></select>
</div>
<div class="form-item" id="sticky-notes-visibility-summary-wrapper">
 Visible on node for me
</div>

<input type="hidden" name="form_build_id" id="form-79ed44abee0c85cb111427b2855abdc0" value="form-79ed44abee0c85cb111427b2855abdc0"  />
<input type="hidden" name="form_token" id="edit-sticky-notes-node-form-form-token" value="ba771c93e8b40664b722dd5cebf08375"  />
<input type="hidden" name="form_id" id="edit-sticky-notes-node-form" value="sticky_notes_node_form"  />

</div></form>
</div></div>
    </div>
  </div>
</div>
<script type="text/javascript" src="/modules/wysiwyg/wysiwyg.js?K"></script>
</body>
</html>
berliner’s picture

hm, I tested with Drupal 6.16. Do you see any errors or warnings in the report? Do you have another drupal version installed somewhere, where you could try to recreate this behavior? It might be some incompatibility with another module. Did you install sticky notes on a live site? If not, you could try to disable some of the contrib modules to see whether that changes anything.

Does this behavior occur with modalframe windows that are not created by the sticky_notes module? You could install the Modal Frame Contrib Package to test this.

Are there any other strange behaviors? Do you use the latest dev-Version from sticky_notes? What jquery, jquery_ui versions do you use?

Sorry, but I can't really do antyhing special since I can't recreate this problem.

AHinMaine’s picture

I work with @calbert. Figured out the issue. If you're enforcing previews in the post settings, you get no buttons. In the sticky_notes.module php code, it's hard-coded to suppress the preview button.

        1187:       $form['buttons']['preview']['#access'] = FALSE;

Flip that to true and you get the preview button which allows you to then preview first, then save. It would be nice if this could bypass the enforced previews entirely and just present the save button.

berliner’s picture

Status: Postponed (maintainer needs more info) » Needs review

Thanks for figuring this out. I made the necessary changes and commited the new version to the dev branch.

The preview setting on the post settings page has now no effect for sticky notes and the save button should always be visible. Thanks for reporting this! And please let me know if that solves your issue.

berliner’s picture

Status: Needs review » Fixed

I am marking this as fixed. If problem persists please reopen this issue.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.