Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
After installing block class 6.x-2.x-dev, I went to an existing menu block and added a class. After saving and returning to the block editor, the class input box was again empty. With 6.x-1.3, I don't have that problem.
Comment | File | Size | Author |
---|---|---|---|
#10 | 812208.patch | 486 bytes | zkday |
#4 | block_class.module.rej_.txt | 829 bytes | Danny Englander |
Comments
Comment #1
BetaTheta CreditAttribution: BetaTheta commentedsubscribing
Comment #2
capellicI'm having the problem described, but I am also having it on 6.x-1.3. But this problem only occurs the *first* time I save it -- when I'm adding the block. If I update an existing block and enter the block class, the class will be saved.
Comment #3
rocketeerbkw CreditAttribution: rocketeerbkw commentedThe problem of not saving class on add block page is solved in #410554: CSS Class Definition on "Add Block" page
Comment #4
Danny EnglanderSame issue. Also, I tried the patch at http://drupal.org/node/410554#comment-2690448 and got a rejection error.
I have gotten this module to work fine in the past so I can only think this is some new issue. The error message in terminal was
"Hunk #1 FAILED at 84. 1 out of 1 hunk FAILED -- saving rejects to file block_class.module.rej"
I am also attaching the code from the rejection file as a text file.
Comment #5
Danny EnglanderNote, I reverted back to 1.3 from 2010-Jan-18 and all is working so I dont know what code was introduced in the new dev version to break what was once working but I am not getting custom classes per block and they are being saved and rendered in the HTML code on any given page where the specified block appears.
Comment #6
berenddeboer CreditAttribution: berenddeboer commentedDon't use the 6.x-2.x branch.
Comment #7
atulkamboj CreditAttribution: atulkamboj commentedI am also having the same issue on 6.x-1.3. Class doesn't save first time when we save the block. If we update an existing block and enter again the block class, the class will be saved second time.
Any progress has been made on this issue??
Comment #8
berenddeboer CreditAttribution: berenddeboer commentedatulkamboy, that's unfortunately how Drupal works. You will notice that nothing you do the first time you create a block gets saved. I.e. included/excluded pages etc.
Comment #9
zkday CreditAttribution: zkday commentedI have a same problem in 7.x-1.x-dev version?
How resolved this?
Comment #10
zkday CreditAttribution: zkday commentedOk, this is patch for this issue!
Thanks!
Comment #11
DYdave CreditAttribution: DYdave commentedHi zkday,
Thanks very much for following up on this issue and submitting a patch.
I have tried to review the patch and your comment, but I'm not completely sure I understand what the problem would be here.
Could you maybe take a concrete example or perhaps elaborate a little bit more on how this patch could be tested? (The context this issue would occur, for example)
Additionnally, could you please also provide the versions of the block_class module on which the problem was encountered and for which the patch should be applied and tested?
I'm not so sure why the submit callback added with
$form['#submit'][] = 'block_class_form_submit';
would fail in your case.Could the default behavior be altered by any other modules running at the same time?
Could you please provide some more details on testing scenarios?
If you could please let us know how we could test the patch, we would be glad to give you further feedback on this bug report or reviews on the patch.
Feel free to let me know if you would have any further questions, issues, comments, suggestions, recommendations or concerns on any aspects of my comment or this ticket in general, I would be glad to provide more information or explain in more details.
Thanks very much in advance for your replies, comments, testing, reporting and reviews.
Cheers!
Comment #13
DYdave CreditAttribution: DYdave commentedThis bug report with a status of needs work has been awaiting response from the author or any other user for almost a month (See #11, last updated: March 10, 2013 at 1:12am):
Therefore, I allowed myself to mark this issue as fixed for now (to give two more weeks to users to react before this gets closed automatically), but feel free to re-open it, or post a new ticket, at any time if you have any further objections with the approach suggested at #11 (we would surely be happy to hear your feedback).
Please let me know if you would have any further comments, feedback, questions, issues, objections, suggestions or concerns on any of my previous comments or this ticket in general, I would be glad to provide more information or explain in more details.
Thanks again to everyone for your help, reviews, feedback and comments on this issue.
Cheers!