Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.In Firefox, when the "+" icon is tabbed to, focus is not visible, and it doesn't expand to show the text "Add to Default Shortcuts." This also causes screen-reader software to read the URL of the link, which is just gibberish, and a user would have no idea what the link is for. This is a failure of a WCAG 2 A success criteria (WCAG 2 2.4.4).
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | add_default_shortcut_811276.patch | 1.07 KB | YaxBalamAhaw |
Comments
Comment #1
Everett Zufelt CreditAttribution: Everett Zufelt commentedA couple of questions.
1. Is there a method of performing this action which doesn't require use of this UI control?
2. What ideas, if any, do you currently have for correcting this problem?
The lack of visible focus is also a violation of WCAG 2.0 - 2.4.7 (AA): Focus Visible
Note: WCAG 2.0 2.4.4 is a priority A success criteria. WCAG 2.0 priority A violations should be considered critical, as they may break functionality for certain users. This is not critical if a comparable method of performing the same function is available.
Comment #2
Bojhan CreditAttribution: Bojhan commentedLets not mark everything critical, it is possible in an other way "add shortcut" to a shortcut set when editing a shortcut set.
Comment #3
YaxBalamAhaw CreditAttribution: YaxBalamAhaw commentedAll that needs to be done is have whatever is done on hover, also be done on focus. Like with this three-liner patch.
Tested in Firefox and Orca. The link expands when tabbed to, and the screen-reader reads the text.
Comment #4
Everett Zufelt CreditAttribution: Everett Zufelt commented@Bojhan
I would like to see evidence of 'everything' being marked critical. I told @YaxBalamAhaw, the GSOC student, to mark any issue violating a WCAG 2.0 priority A success criteria as critical. If there is indeed a comparable and accessible method to perform this function then I agree, the issue is not critical, as I stated in my first comment.
Comment #5
David_Rothstein CreditAttribution: David_Rothstein commentedChanging status - looks like there was a crosspost.
And, subscribe :)
Comment #6
David_Rothstein CreditAttribution: David_Rothstein commentedSeems like a no-brainer, and the patch works as advertised - let's get it in!
My only other comment is that I noticed there is one other place in this CSS file that uses hover without focus... Might be worth throwing in a fix for that as well (although that one isn't as important since it only affects background color, not functionality).
Comment #7
Bojhan CreditAttribution: Bojhan commented@Everett Zufelt Ohh that was just a comment towards our critical issue queue not going down, but up :(
Regarding actual critical status of accessibility issues, I would definitely call violations of WCAG something critical. However given that we don't validate at all yet? It might make sense only to mark critical status to issues that completely render something completely unusable as opposed to making it though to work with.
Comment #8
Dries CreditAttribution: Dries commentedDo we need to have on hover and on focus, or can we do on focus only? Just curious.
Comment #9
casey CreditAttribution: casey commentedRelated issues:
#666698: Add-remove-shortcut link issues
#782334: Improve shortcuts look in page titles
Comment #10
Everett Zufelt CreditAttribution: Everett Zufelt commented@David_Rothstein
A good idea to use focus anywhere that hover is used and that can receive keyboard focus. This makes it easier for a keyboard only user to properly track focus. In the same way that a change in the color is a visual affordance to a mouse user, it is also an affordance to sighted keyboard only users.
Comment #11
YaxBalamAhaw CreditAttribution: YaxBalamAhaw commented@David_Rothstein Yeah, I saw the other place in the CSS file using hover without focus, but I wasn't sure what it was for, so I didn't touch it. But, after looking at it again, it's there to keep the background of the "active" shortcut link in the toolbar from changing color when hovered over. I believe that this should stay as it is, so the color does change to indicate focus, and to achieve success with WCAG 2.0 - 2.4.7 (AA): Focus Visible.
@Dries Yes, we need both. If only focus is used, then the icon wouldn't expand on hover (just tested it to make sure).
Comment #12
Bojhan CreditAttribution: Bojhan commented@Dries Ok, seems like its needed.
Comment #13
mgiffordThe patch in #3 worked fine for me. Agreeing with RTBC!
Comment #14
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.