Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The recent addition of 'type' information in the layer table didn't also add a proper header for the new column.
The attached patch adds it.
Comment | File | Size | Author |
---|---|---|---|
#8 | LayersTypeHeader2.patch | 373 bytes | strk |
LayersTypeHeader.patch | 455 bytes | strk | |
Comments
Comment #1
tmcw CreditAttribution: tmcw commentedLooks like you're behind head; can you try updating? The current code will add a header - this patch adds the type header right under where it already adds a header.
Comment #2
strk CreditAttribution: strk commentedI'm up-to-date on the DRUPAL-6--2, should I track HEAD instead ?
Comment #3
strk CreditAttribution: strk commentedMy patch is against r1.1.2.34
Comment #4
tmcw CreditAttribution: tmcw commentedIt's all being tracked in DRUPAL-6--2, but isn't the logic on line 382 specifying a type header for object lists that are layers? Try reverting your patch and clearing caches? This is working on my side, and this patch will add headers for styles, not layers or presets.
Comment #5
strk CreditAttribution: strk commentedDoh, you're right, it's the wrong block.
Still, reverting my patch drops the Type from the Layers tab too
so must be something with line 686 failing
if ($type == 'layers') {
I think I did drop drupal cache (if 'drush cc' is enough for that).
I surely did drop the browser one.
Comment #6
strk CreditAttribution: strk commentedActually, the block is entered correctly. Maybe I'm looking at the wrong file ?
The problem is on the screen shown with path 'admin/build/openlayers/layers'
Comment #7
tmcw CreditAttribution: tmcw commentedAh, the problem is that it should be an elseif, not an if in the switch. Here's to late-night tired programming.
Comment #8
strk CreditAttribution: strk commentedConfirmed. Patch (for what is worth) added.
Comment #9
tmcw CreditAttribution: tmcw commentedCommitted in http://drupal.org/cvs?commit=372488
Thanks!