The attached patch removes the "Search engines" tab in XMLSitemap settings and moves the settings themselves onto the settings page.

CommentFileSizeAuthor
#4 Move_engine_settings_to_settings_page.patch1.86 KBAnonymous (not verified)
Move_engine_settings_to_settings_page.patch2 KBAnonymous (not verified)
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, Move_engine_settings_to_settings_page.patch, failed testing.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Category: task » feature
Status: Needs work » Needs review

Why would we want to do that? It would clutter up the admin/settings menu even more.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Needs review » Needs work
Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Title: Move engine settinngs onto the "Settings" page for greater usability » Move engine settings onto the XMLSitemap Settings with the rest of XMLSitemap settings
Status: Needs work » Needs review
FileSize
Move_engine_settings_to_settings_page.patch1.86 KB

Doh! I had a mistake in the patch. Also, I suppose I didn't really do a good job of explaining where I want to move the contents. Let me fix the title to be more accurate.

Status: Needs review » Needs work

The last submitted patch, Move_engine_settings_to_settings_page.patch, failed testing.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

Joshua, I understand what's happening in the patch, but I don't understand the reason behind it. Can you explain how this will be more usable besides putting all settings into one page that's already kinda crowded (especially for people without vertical tabs installed for D6)?

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein commented

This patch is against Drupal 7, so essentially everyone will already have vertical tabs. However, overcrowding the settings page still seems like a real concern.

I assume the rationale behind the patch is that without it, the menu local tasks are themselves kind of overcrowded. I don't think it's at all clear to a user why "search engines" is special enough (compared to the module's other settings) to get its own tab. Is there a reason to expect they will need to configure that more often than other settings which the module provides?

Other alternatives to this patch might involve (a) using secondary local tasks rather than primary local tasks to split things up, or (b) perhaps choosing something else other than the "Search engines" setting to have the honor of its own tab instead... e.g., seems like the vertical tabs themselves (with the summary/configuration options for each menu/content type/etc.) would be a good candidate to live on their own tab, to the extent that they are likely to be fiddled with somewhat often as a site grows?

Just throwing out some ideas there :)

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

Hrm, if we are going to put search engine settings into vertical tabs, we need to be able to provide a summary for the tab somehow. With all the engine settings I don't think we can do that, which is why it made sense to me to have them on a separate page.

I'm thinking maybe a little reorganization of the menu structure:

Sitemaps
- List (default)
- Add/Edit/Delete pages
Links
- Summary/Settings (the current vertical tab listings on the settings page with links to administer node types, etc)
- Custom links
- Index (what is currently the rebuild page)
Settings (non-verticaltabbed feildsets with normal, advanced, and search engine settings)