Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The new administration page (?q=admin) breaks in many standards-compliant themes because there is no clear after the floating (left and right block) divs.
This patch adds a simple div class="clear-both" immediately after the floating divs.
Seems to fix the problem.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | admin-no-clears.jpg | 74.41 KB | jjeff |
| #2 | markup.patch | 4.23 KB | m3avrck |
| system-adminpage-clear.patch | 493 bytes | jjeff | |
Comments
Comment #1
Steven CreditAttribution: Steven commented'clear-block' is not the same as "clear: both". You should set the class on the container itself for proper usage.
Comment #2
m3avrck CreditAttribution: m3avrck commentedThis patch cleans up the markup on administratin pages, along with corresponding CSS. It also moves theme specific CSS into their respective themes. Also should fix the clearing issue on other themes as well.
The result: less CSS, improved markup, and more appealing admin pages depending on the theme.
Comment #3
kkaefer CreditAttribution: kkaefer commented+1 on this. Tested it. Works fine. Setting this RTBC.
Comment #4
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.
Comment #5
jjeff CreditAttribution: jjeff commentedThe change that was committed does not fix the problem that I originally posted a fix for.
The floats on the admin page are still not cleared so any divs that surround them will collapse.
See the attached jpg for an example of this. This will not happen in tables-based layouts, but standards-compliant layouts will have this problem.
Comment #6
jjeff CreditAttribution: jjeff commentedPlease note that my original 1 line patch did solve this problem.
Comment #7
m3avrck CreditAttribution: m3avrck commentedNot applicable to Drupal, this is a problem with your theme.
Comment #8
(not verified) CreditAttribution: commented