Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The word "presets" is misleading. It should be changed to Maps.
This should probably get done sooner than later as the module is still marked as alpha (though that doesn't seem to mean too much in the Drupal community), and this is not a change that should happen once it is in beta. This will include the following:
* Database table name
* Hook changes
* Function change
* Interface wording
Most of the changes are internal and the database changes can be managed with an update function. The hook change will need to include some notification to developers.
Comments
Comment #1
tmcw CreditAttribution: tmcw commentedThis should happen after the module is released as a 2.0, and this shift should be a 2.1 version which also incorporates UI improvements, in my opinion.
Comment #2
tmcw CreditAttribution: tmcw commentedMarking as postponed, meaning that this will come after 2.0 stable.
Comment #3
zzolo CreditAttribution: zzolo commentedSounds good.
Comment #4
tmcw CreditAttribution: tmcw commentedDone in D7.
Comment #5
zzolo CreditAttribution: zzolo commentedHey @tmcw, this is awesome. Is this just a cosmetic change (menu titles) or a fundamental change (DB table change)?
Comment #6
zzolo CreditAttribution: zzolo commentedMaybe I am missing something, but everything still says Presets in D7. Re-opening.
Comment #7
zzolo CreditAttribution: zzolo commentedI have started a new branch for this issue as its fairly substantial and will need some testing:
http://drupal.org/node/177400/git-instructions/806318-rename-preset-to-maps
Some automatic changes:
Some non-automatic changes:
Still needs a little love, but initial check seems to be ok.
Comment #8
phayes CreditAttribution: phayes commentedThis is now done
Comment #9
dasjoafter upgrading, the old map preset which i had stored in features was lost.
i was able to recover functionality by comparing a fresh "map" feature export to the old "map preset" export and renaming definitions in the feature module files accordingly.
we might need to open another issue for the features integration part of this issue, but i think old preset should not get lost regardless if one uses features or not
Comment #10
dasjoit might also be of interest to follow the following features issue in order to find out how provide a features upgrade path for changing export definitions #1113060: Fix upgrade path for recent views integration changes
Comment #11
zzolo CreditAttribution: zzolo commentedI really have little idea on how to address this issue. I know CTools allows a plugin to define specific hooks for it, maybe this is the key?
Comment #12
zzolo CreditAttribution: zzolo commentedSo, with @phayes' help, we came up with a hackish backwards compatibility solution. Basically, in the map hook implementation, we call hook_presets to get any old presets, and go through any features that have any presets.
This is not full backwards compatibility as features will look weird, but it will allow for maps to still work and for messages to be shown to administrators to make changes.
The message part has not been committed yet.
Comment #13
zzolo CreditAttribution: zzolo commentedOk, set a requirement that tells the user about features or traditional hook implementations are in use. I also added a Drupal message on OL pages if this is the case.
So, the last thing to do is update the documentation page: http://drupal.org/node/1136810
Comment #14
zzolo CreditAttribution: zzolo commentedAll done! Haven't really heard any issue yet about this.