I have coded in the location.my.inc for location support for Google Maps.

Please bundle this with future Location releases.

I also did not provide this in diff format as the change is quite significant. It would be more cost effective to just send in the affected file.

CommentFileSizeAuthor
location.zip1.34 KBDeslack
#5 Add_Malaysia_my_support_for_Google_Maps.patch3.05 KBpashazubenko@gmail.com
#9 interdiff-805186-9.txt1.43 KBBober
#9 Malaysia_my_support_for_Google_Maps-805186-9.patch1.43 KBBober
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Title: Malaysia (my) Support » Malaysia (my) Support location.my.inc location.xx.inc
Status: Patch (to be ported) » Needs review

is this location.my.inc like location.xx.inc?

Deslack’s picture

Deslack CreditAttribution: Deslack commented

Yes.

ankur’s picture

ankur CreditAttribution: ankur commented
Assigned: Deslack » Unassigned
Category: bug » task

Would be nice if some could do a once over on the location.my.inc file and see what, if anything, would need to happen to make it work with the 7.x-3.x/7.x-4x branches.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented
Version: 6.x-3.x-dev » 7.x-3.x-dev
Status: Needs review » Patch (to be ported)

All data updates have to be rolled against latest 7.x-3.x-dev and after that backported to 6.x-3.x
This one has to be uploaded in http://drupal.org/patch git diff format

pashazubenko@gmail.com’s picture

pashazubenko@gmail.com CreditAttribution: pashazubenko@gmail.com commented
Issue summary: View changes
FileSize
Add_Malaysia_my_support_for_Google_Maps.patch3.05 KB

Add patch for this problem

pashazubenko@gmail.com’s picture

pashazubenko@gmail.com CreditAttribution: pashazubenko@gmail.com commented
Status: Patch (to be ported) » Needs review
podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented
Status: Needs review » Fixed

#5 commited
Thanks!

  • podarok committed ee4331e on 7.x-3.x authored by Pavel Zubenko 
    Issue #805186 by Pavel Zubenko | Deslack: Malaysia (my) Support location...
Bober’s picture

Bober CreditAttribution: Bober commented
Status: Fixed » Needs review
FileSize
Malaysia_my_support_for_Google_Maps-805186-9.patch1.43 KB
interdiff-805186-9.txt1.43 KB

Hi all.
It seems that in location_map_link_my_mapquest elseif (count($query_params) > 0) is not needed. Removed it and added some drupal coding style.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented
Status: Needs review » Fixed

pushed to repo
Thanks!

  • podarok committed a3ec225 on 7.x-3.x authored by Bober 
    Issue #805186 by Bober, Pavel Zubenko | Deslack: Malaysia (my) Support...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.