There is some left-over code in filter.module that is unused in the function filter_admin_overview(). Probably left-over from when the theming was done inside that function instead of in theme_filter_admin_overview().

The $rows = array() and $row = array() are unneeded as both variables are not used.

CommentFileSizeAuthor
#6 filter.no-rows.patch_1.txt1.15 KBRobrecht Jacques
#2 filter.no-rows.patch_0.txt1.11 KBRobrecht Jacques
filter.no-rows.patch.txt865 bytesRobrecht Jacques
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented
Status: Needs review » Needs work

Looks like $rows needs to be added to theme_filter_admin_overview().

Robrecht Jacques’s picture

Robrecht Jacques CreditAttribution: Robrecht Jacques commented
Status: Needs work » Needs review
FileSize
filter.no-rows.patch_0.txt1.11 KB

Adding $rows = array() to theme_filter_admin_overview().

killes@www.drop.org’s picture

killes@www.drop.org CreditAttribution: killes@www.drop.org commented
Version: 4.7.3 » x.y.z
Status: Needs review » Reviewed & tested by the community

applied to 4.7,moving to cvs. Please apply or move back and mark as fixed.

Dries’s picture

Dries CreditAttribution: Dries commented

Doesn't apply against CVS. We'll want to re-roll this against head.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented
Status: Reviewed & tested by the community » Needs work
Robrecht Jacques’s picture

Robrecht Jacques CreditAttribution: Robrecht Jacques commented
Status: Needs work » Needs review
FileSize
filter.no-rows.patch_1.txt1.15 KB

Rerolled against HEAD.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Needs review » Reviewed & tested by the community
Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks Robrecht!

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)