update_prepare_d7_bootstrap() docs say

No access check has been performed when this function is called, so no changes to the database should be made here.

but it creates tables registry, registry_file and cache_bootstrap.

CommentFileSizeAuthor
#4 update.inc_.patch729 bytesglipay
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jbrown’s picture

Component: base system » documentation
Priority: Normal » Minor
jhodgdon’s picture

Issue tags: +Novice

Odd. It seems like any function doc should not say what the function "should" do, when the function has no arguments like this one. It should just document what the function does... I think that line should just be removed.

http://api.drupal.org/api/function/update_prepare_d7_bootstrap/7

Good project for a novice doc contributor...

Damien Tournoud’s picture

I agree with #2.

To be fair, I think the intend of this comment was to say that no *irreversible* modification to the database should be made. Creating a table if it doesn't exist is perfectly safe.

glipay’s picture

Assigned: Unassigned » glipay
Status: Active » Needs review
FileSize
729 bytes

changed the documentation to read "No access check has been performed when this function is called, so no irreversible changes to the database are made here."

jhodgdon’s picture

Status: Needs review » Reviewed & tested by the community

Looks fine - thanks!

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD.

Status: Fixed » Closed (fixed)
Issue tags: -Novice

Automatically closed -- issue fixed for 2 weeks with no activity.