shouldn't the "post new blog entry" link have 'action-links' class?

that image ^ embedded:

They should.... but they are made completely differently:

The 'add user' link is made by hook_menu as a MENU_LOCAL_ACTION.

The 'add blog' link is hardcoded HTML at the top of the blog page callback, blog_page_user().

So we're looking at spoofing that class in to the 'add blog' link, which is sort of a kludge :/

@ Joachim - is that still the case? I thought it was fixed with #542658-79: Move action "tabs" out of local tasks

Dries committed that on December 3, 2009 and I updated my CVS checkout of D7 in the last few days -- so I'd say no :)

Guys, "post new blog entry" what you are witnessing here is nothing but a historical landmark: a contextual action link introduced in Nov 24 2004 to Drupal (commit here, the original issue here #10990: Add "new blog post" link to the top of user blog pages). According to a timeline, it was likely Drupal 4.5.

There were the dark days when usability was a still a novelty word in Drupal. Yes, it was hardcoded and never properly abstracted but nevertheless important. It was a total break from the usual "drupal is mo-du-lar, go see /node/x to view, /node/x/edit to edit, /node/add/x to add" robot talk and actually offered a right link in a right place for users.

Unfortunately as there is almost no attention to blog.module any more, that small mighty link never go converted to D7 action links (what it essentially is, way ahead of its time).

So, yes, it needs proper conversion not CSS-faking.

> So, yes, it needs proper conversion not CSS-faking.

I'm not sure we can do that, since the link it gives already exists elsewhere in the menu structure.

This should work.

Updated patch

Any suggestions on how to fix the test failure?

The problem is the new patch does not show a "You are not allowed to post a new blog entry." in the case where the user does not have permission to create blog posts - it just does not show the link to create a new blog post.

I would say the test needs changing.

The menu system can't show you links you don't have access to. And anyway, showing you a text saying something you can't do is rather odd.

I have changed the text to make sure there is no "create new blog entry" text in such a case.

+++ modules/blog/blog.pages.inc	2010-04-30 18:54:09.772500000 +0100
@@ -42,6 +27,8 @@ function blog_page_user($account) {
+  $build = array();
+

What's this bit for? Doesn't seem connected with anything else in the patch.

86 critical left. Go review some!

Regarding the 'you may not...' link, I've just seen forum module does this:

        // Authenticated user does not have access to create new topics.
        if ($user->uid) {
          $links['disallowed'] = array(
            '#theme' => 'menu_local_action',
            '#link' => array(
              'title' => t('You are not allowed to post new content in the forum.'),
            ),
          );
        }

(over at #786620: Regression: Add new forum topic not visible within a forum).

So maybe we should too, when the user is looking at their own blog but may not post there.

@ comment 19 - the end of the function has a return return $build; so we need to make sure it is always initialised and it fixes the fatal error reported in comment 10.

The other option was to remove the + to where the array is added to ($build += ...) but that was inside an if statement so I thought this was cleaner.

> @ comment 19 - the end of the function has a return return $build; so we need to make sure it is always initialised and it fixes the fatal error reported in comment 10.

Sure, but it seems unrelated to the changes we are making here -- it's in a function we don't touch apart from that.

Here's a new pach, without that change, with the 'you may not' link, and *with* the test kept in as it should now pass.

The patch over at #671452: Blog Actions CSS has passed the tests, but I have not had a chance to test.

Should this issue be marked duplicate?