Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The system menu blocks look pretty ugly at this point up in the header. I'm working on a patch that will make them look like the Primary Menu links and allow for drop-down menus.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | dropdowns.patch | 4.82 KB | deggertsen |
| #2 | Screen shot 2010-04-21 at 6.01.34 PM.png | 91.13 KB | deggertsen |
Comments
Comment #1
Jeff Burnz CreditAttribution: Jeff Burnz commentedMarking this as a duplicate of #777778: Rethink header region block handling, I don't think we need two open issues for cleaning up menu blocks in the header.
Comment #2
deggertsen CreditAttribution: deggertsen commentedI've attached the patch along with a screenshot. Review and enjoy!
Comment #3
Jeff Burnz CreditAttribution: Jeff Burnz commentedThis wont work with IE6. There are at least two very good modules that can do this better - Nice Menus and Superfish, both of which do work with IE6 by providing Javascript support. :hover is just doesnt work in IE6 on anything but anchors.
My point being that perhaps, if we wanted this sort of thing a better solution might be to just add a new region, such as $menu_bar, and conditionally print this region if a block gets put in it, eg.
print $menu_bar ? $menu_bar : $primary_links sort of thing
Your original post is a bug report which is why it got marked as a duplicate, I didnt realise you were making a feature request, can you change it please.
Comment #4
deggertsen CreditAttribution: deggertsen commentedI would definitely like to see this theme support this kind of menu system. I realized that what I had done doesn't support IE6 so this does need work and I like the idea of adding it as a new region. I was also thinking the header region should be aligned to the right instead of where it is now but of course that is another issue/feature request.
So I guess my question is if we should just make it so that the CSS supports nice menus and/or superfish or if there is another solution?
Comment #5
Jeff Burnz CreditAttribution: Jeff Burnz commented"should just make it so that the CSS supports nice menus and/or superfish",
That is something I would very much like to see, so many users want drop menus etc it would be great if at least one of those modules looked good right out of the box.
The other way to go about it, is if Bartik were to get into core, then I would bet that both module maintainers would accept patches that add a "Bartik" style to their modules...
Comment #6
deggertsen CreditAttribution: deggertsen commentedI'm going to postpone work on this then until we see more support for D7 from the Nice Menus and/or Superfish modules. Once we see a D7 release from them I think it will be easier to decide the final action plan.
Comment #7
deggertsen CreditAttribution: deggertsen commentedAlso changing the name of this feature request.
Comment #8
deggertsen CreditAttribution: deggertsen commentedComment #9
jensimmons CreditAttribution: jensimmons commentedMoving to Drupal project, and pushing to D8.
Comment #10
anne1960 CreditAttribution: anne1960 commentedHas anyone found a solution to this superfish menu in the bartik theme??
Comment #11
jjwhitney CreditAttribution: jjwhitney commentedI've just created a simple subtheme for Bartik that utilizes superfish menus.
Comment #12
anne1960 CreditAttribution: anne1960 commentedwonderful...this one works...thanks a lot.
At least an easy install without having to mess in the code
Comment #13
anne1960 CreditAttribution: anne1960 commentedOne additional question though. I did enable this theme. But I can't change colors for the appearance . Do I have to put this subtheme in the core Bartik file?
Comment #14
jjwhitney CreditAttribution: jjwhitney commentedHmmm... I guess the color feature doesn't get passed down to subthemes. I've fixed the problem, so try downloading again. Let me know if you have any problems. Thanks!
Comment #15
Jeff Burnz CreditAttribution: Jeff Burnz commentedHey guys, I really appreciate that you have some code you want to share and discuss, but this is the Bartik issue queue, and Drupal core at that, please take the discussion somewhere else, we use these issues to track actual issues, so what you are posting here is noise for us because its not pertaining to the issue at hand. Thanks.
Comment #16
anne1960 CreditAttribution: anne1960 commentedIt works. thanks
Comment #17
Jeff Burnz CreditAttribution: Jeff Burnz commentedAfter some though on this the only way I really see this happening in core is if Main menu and Secondary links become blocks (this could really happen in D8) and Nice menus and Superfish include "Bartik" styles, although we could still have a color issue so some minor support may be required there, which I would not object to.
@anne1960 - please keep it on topic.
Comment #18
qipengos CreditAttribution: qipengos commentedHow to apply this patch? In the wwwroot dirctory?