Calculate subtotals for non-node views, e.g., Ubercart orders [#776848]

When using a Views Calc Table to display Ubercart orders, the dblog would contain errors about invalid SQL syntax related to this part of the query:

AND (node.nid IN (,,,,,,,,,,,,,,,,,,,,,,,,))

The error is because the view doesn't involve nodes, it involves Ubercart orders. The attached patch changes two lines of views_calc_table.inc to not assume the node table and node ids when calculating subtotals. Instead it uses the view's base_table and base_field members (which are "node.nid" for nodes and "uc_order.order_id" for Ubercart orders).

I built the patch against 6.x-1.3, and it applies cleanly to 6.x-1.x-dev (2009-Nov-07).

Comment	File	Size	Author
#5	views_calc_1020936_5_base.patch	2.69 KB	miro_dietiker
#4	views_calc_1020936_2_base.patch	2.48 KB	miro_dietiker
#1	views_calc_use_base_field.patch	906 bytes	mikec

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

mikec CreditAttribution: mikec commented 20 April 2010 at 21:01

File	Size
views_calc_use_base_field.patch	906 bytes

Comment #2

3dloco CreditAttribution: 3dloco commented 11 June 2010 at 02:52

Status:

Active

» Reviewed & tested by the community

Thanks mikec your patch worked for me!

Comment #3

basvredeling

Dutch

Amsterdam

CreditAttribution: basvredeling commented 4 October 2010 at 10:42

Worked for me too, not for ubercart stuff but for time_tracker entries. If you create a view for something besides nodes. say: node revisions, users or taxonomy terms, the entry id isn't "nid" either. This patch should work for every alternative field id for which a views result is generated.
For the real nitpickers out there, the nomenclature in the code should be adapted likewise. So instead of a $nid[] array, a $base_field[] array (or something like it) should be populated.

Thanks mikec.