When there's a feature that less than 1% of sites need, especially when it would negatively impact the other 99% of sites, rather than putting it in core, we try to allow contrib modules to account for it. This would allow those bidding for US government contracts to meet the needs of the NIST directive, and it would also allow people to use Damien's Drupal C extension to replace parts of common.inc

CommentFileSizeAuthor
#11 0001-Issue-769648-Make-common.inc-swappable.patch6.3 KBmarvil07
#8 variable_common_inc_8.patch1.65 KBjoshuajabbour
#5 variable_common_inc_4.patch1.31 KBjoshuajabbour
#3 variable_common_inc_3.patch1.31 KBjoshuajabbour
#1 variable_common_inc.patch780 bytescatch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Active » Needs review
FileSize
variable_common_inc.patch780 bytes

Patch.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Title: Make menu.inc and common.inc swappable » Make common.inc swappable

menu.inc is already swappable.

joshuajabbour’s picture

joshuajabbour CreditAttribution: joshuajabbour commented
FileSize
variable_common_inc_3.patch1.31 KB

attached is a fix to the patch in #1 to remove the double slashes in the path. It also fixes the same problem in the menu.inc inclusion...

Status: Needs review » Needs work

The last submitted patch, variable_common_inc_3.patch, failed testing.

joshuajabbour’s picture

joshuajabbour CreditAttribution: joshuajabbour commented
Status: Needs work » Needs review
FileSize
variable_common_inc_4.patch1.31 KB

reroll

Status: Needs review » Needs work

The last submitted patch, variable_common_inc_4.patch, failed testing.

joshuajabbour’s picture

joshuajabbour CreditAttribution: joshuajabbour commented

argh

joshuajabbour’s picture

joshuajabbour CreditAttribution: joshuajabbour commented
Status: Needs review » Needs work
FileSize
variable_common_inc_8.patch1.65 KB

ok, one last try. no more git diff. silly testbot...

joshuajabbour’s picture

joshuajabbour CreditAttribution: joshuajabbour commented
Status: Needs work » Needs review
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Version: 7.x-dev » 8.x-dev
Status: Needs work » Needs review
marvil07’s picture

marvil07 CreditAttribution: marvil07 commented
FileSize
0001-Issue-769648-Make-common.inc-swappable.patch6.3 KB
moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented

IIRC, the very first versions of multi-site (circa 4.5) let you swap /includes files just like modules and themes. So, you would add a sites/all/includes folder and put your own common.inc there. Same for sites/foo/includes. Maybe we should go back to this.

This is a bit tricky for files that are needed before conf_path(), but we can probably find a settings.inc based solution for these.

valthebald’s picture

valthebald
Location Sofia
CreditAttribution: valthebald commented

#11: 0001-Issue-769648-Make-common.inc-swappable.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 0001-Issue-769648-Make-common.inc-swappable.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented
Issue summary: View changes
Status: Needs work » Fixed

common.inc doesn't really exist anymore at that point in time.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.