Search.module in-code documentation refers to hook_search() which no longer exists in D7 [#767822]

Comment	File	Size	Author
#2	search-mention-hook-search-info-not-hook-search-767822.patch	630 bytes	mlncn

#1	search-mention-hook-search-info-not-hook-search-767822.patch	0 bytes	mlncn

Comment #1

mlncn CreditAttribution: mlncn commented 11 April 2010 at 07:22

Priority:	Normal	» Minor
Status:	Active	» Needs review

File	Size
search-mention-hook-search-info-not-hook-search-767822.patch	0 bytes

This code also defines this documentation page http://api.drupal.org/api/group/search/7 so the patch also fixes that. Since hook_search_execute() can still be used, this is the only documentation change.

Log in or register to post comments

Comment #2

mlncn CreditAttribution: mlncn commented 11 April 2010 at 07:26

File	Size
search-mention-hook-search-info-not-hook-search-767822.patch	630 bytes

with a patch with content this time!

Log in or register to post comments

Comment #3

jhodgdon

she/her

English

CreditAttribution: jhodgdon commented 11 April 2010 at 14:03

Good catch. I'm not sure I am completely happy with the solution, because it's not just hook_search_info() that would be used to implement searching. Maybe it should say "without hook_search_info() and related hooks". ?

Log in or register to post comments

Comment #4

andrew.elvis CreditAttribution: andrew.elvis commented 11 April 2010 at 18:04

Status:

Needs review

» Reviewed & tested by the community

I guess that works.

Log in or register to post comments

Comment #5

Dries CreditAttribution: Dries commented 11 April 2010 at 18:54

Status:

Reviewed & tested by the community

» Fixed

Committed to CVS HEAD. If we want to refine the documentation, feel free to re-open the issue. No problemo. :)

Log in or register to post comments

Comment #6

mlncn CreditAttribution: mlncn commented 12 April 2010 at 00:07

Status:

Fixed

» Needs review

From my reading of the code, you could - and likely would - use hook_search_execute with your custom tab with extra form fields, and i don't know that there are any other hooks tightly coupled to hook_search_info(), so the five character patch may do it.