I've nearly finished everything I set out to do in this round of updates. There are a few more feature requests that I will probably park because the underlying SWF Tools is looking pretty good now.

But I was wondering if many people have tried the BETA (or the snapshot from DRUPAL-6--3), and whether it was working out? The new features make sense? Any bugs? Any hiccups in the upgrade?

Thanks!

CommentFileSizeAuthor
#6 add-player-map-to-beta4.patch1.05 KBSchnWalter
#6 map.png18.67 KBSchnWalter
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Stuart Greenfield’s picture

Title: How is BETA3? » How is BETA4?
Version: 6.x-3.0-beta3 » 6.x-3.0-beta4

No feedback on BETA3, so either no-one used it, or no-one found any issues!

Changing title on this to collect feedback on BETA4. If you find an issue then please raise them separately, but use this thread to capture general observations/comments!

SchnWalter’s picture

beta4 seems to work ok for me... great job...
i've made a solution for this #659234: Can 1 Pixel Out be set to non-minimized? could you please take a look

SchnWalter’s picture

is it ok for you if i try to make a clean, working onepixelout v2? i've seen the bugs concerning the 1 Pixel Out MP3 Player and now i'm working on solving a few of them...

this community helped me a lot, now it's time for me to help others, i'm not an experienced drupal developer... but i think that with a little help and a few hints i can do my job.

so should i work on this, or are you on the point of finishing them yourself?

Stuart Greenfield’s picture

BETA-4 has a new module "WordPress audio" that implements the newer version of the one pixel out player. I think in the linked post you have perhaps created a module that does the same?

The WordPress audio module might not have all the features in it (can't remember off hand), but if you want to have a look and can implement any missing stuff that would be great!

SchnWalter’s picture

ups... my mistake most of the features are there... i'll check and make some patches if i find anything...

thank you for the response.

SchnWalter’s picture

FileSize
18.67 KB
1.05 KB

added a player map in the collor section for "WordPress audio"

attached a png and patch a file

SchnWalter’s picture

i've seen that transparentpagebg and pagebg variables for the 'wordpress audio' player don't affect the transparency/colour of the player background... regardless of what value wmode has if wmode is not set to transparent... i've tried making these variables work directly on a clean html file, but it did not work for me, probably it's a bug in the player.

i think that these hints in the admin area could be useful for those who never used this module before.

  // add hints after this section inside swftools_wpaudio_profile_form()
  // See if colorpicker 2 is loaded
  //$can_pick = function_exists('colorpicker_2_or_later');

  // Add hints
  $hints = array();

  // install colorpicker hint
  if (!$can_pick){
    $hints[] = t('Install !colorpicker module in order to have a colorpicker in the color forms.', array('!colorpicker' => l(t('Colorpicker'), 'http://drupal.org/project/colorpicker', $options = array())));
  }

  // temporary hint, until the player transparency/color is solved
  $params = variable_get('swftools_params', FALSE);
  if ($params['wmode']!='transparent'){
    $hints[] = t('You can set !wmode to transparent in order to have a transparent background for all of your swf files. Ex: use the player with a collored theme. Or you cans set !bgcolor to match your requirements.', array('!wmode' => l(t('Window mode (wmode)'), 'admin/settings/swftools/embed'), '!bgcolor' => l(t('Background color (bgcolor)'), 'admin/settings/swftools/embed')));
  }


  if ($hints){
    $form['swftools_wpaudio']['hints'] = array(
        '#type' => 'item',
        '#title' => t('Hints'),
        '#value' => theme_item_list($hints,'','ul'),
      );
  }

If it is ok for you... i would like to make some links in the $tabs area... so that it would be easier to navigate between the pages of the swftools modules. just like the links that all other useful/great modules have.

P.S. I did not add a second patch because i'm not sure how multiple patches should be made/applied.
P.S.2 thank you for the module :D

Edit: made a little modification... sorry, not a native english speaker here

SchnWalter’s picture

here is another update, cleaned up the theme_swftools_wpaudio_accessible function

function theme_swftools_wpaudio_accessible($id, $visible) {
  $actions = array();
  
  // Note the class names - this is what lets the JavaScript determine what to attach to, and with what action
  $lClass = $visible ? '' : 'swftools-accessible-hidden';
  $pClass = 'wpaudio-accessible-open-'.$id;
  $sClass = 'wpaudio-accessible-close-'.$id;
  
  $actions[] = l(t('Play'), '', array('fragment' => ' ', 'external' => TRUE, 'attributes' => array('class' => $pClass)));
  $actions[] = l(t('Stop'), '', array('fragment' => ' ', 'external' => TRUE, 'attributes' => array('class' => $sClass)));

  // Convert the actions array to a themed list of items.
  $output = theme_item_list($actions,'','ul',array('class' => $lClass));
  
  return $output;
}

I hope i'm not only giving you more work... hope this helps.

P.S do you have certain plans, guides for the module... did you make a list somewhere? so that i can help you progress with your work?

Stuart Greenfield’s picture

Go for it!

I don't have a written plan because no-one else wanted to help out before so it's just in my head!

Will look at building in these contributions shortly - thanks!!

Stuart Greenfield’s picture

@sumy - you learn something everyday - theme_item_list() - very neat!

I like your code format, so I've built that in to WP Audio, and will port it to the other players now :-)

SchnWalter’s picture

I want to read this before I do anything else... and beside that I have some work to do, but I will study your module... and I promise to help you with it...

regards, walter

SchnWalter’s picture

Stuart, I would like to help with the issue cue since it's a long list...

I would like to know a few things:

  • are you planning a future release for the 2.x branch, and if not... do you want people switch to 3.x?
  • what about drupal5...
  • what about issues of 2.x that have been fixed in 3.x, do you want to mark them as closed?

I would like to start working on those... and let you do your job, developing/improving these great modules.

EDIT: just read this

xmacinfo’s picture

Upgraded to BETA4 (on a dev computer, not production) today and cannot get it to perform correctly.

I often get this error:
The combination of flowplayer3_mediaplayer with video is not valid. Check that the player is available and that it supports the requested action.

... where sometimes the video plays(1).

Or the famous: “You are missing some Flash content that should appear here! …”.

I tried to use the same settings as SWF Tools 6.x-2.5, but still have problems.

(1) I noticed that some JS were not loading when the video was displayed. But upgrading to swftools 6.x-3.x-dev (april 24) solved that issue.

I will try to uninstall SWF Tools completely (by using the uninstall tab) and reinstall again.

So far moving to BETA4 does not work for me.

Note: I am also using Flash Node on this site.

xmacinfo’s picture

I found out the fix for this error:

The combination of flowplayer3_mediaplayer with video is not valid. Check that the player is available and that it supports the requested action.

The old version of my [swf] tag specified a player attribute -> player="flowplayer3_mediaplayer"

Removing this attribute resolved the issue.

So upgrading would require using basic [swf] tags if not working the first time.

Stuart Greenfield’s picture

@xmacinfo - you found a bug! The module is supposed to map the names over automatically, but I put the wrong source name!

Change line 2389 of BETA-4 swftools.module to 'flowplayer3_mediaplayer' => 'flowplayer3', and it will fix it! Fixed on DRUPAL-6--3.

Fair point about the uninstaller - I need to write that.

Not sure which / why some JS didn't load, but if it's ok in the 6.x-3.x-dev package then maybe I fixed something :-)

xmacinfo’s picture

Beta4 should indeed be replaced by a new release as soon as possible.

I now updated a production site (oh no!!!) to 6.x-3.x-dev (april 29) without a single error messsage or hitch. I just needed to reconfigure the player and colours. Even the player="flowplayer3_mediaplayer" filter attribute does not fire any error.

As soon as a new release is made available, though, I will return the production site to releases instead of dev.

dre2phresh’s picture

Isn't the OnePixelOut Player and WPAudio Player modules the same? Why have both?

Stuart Greenfield’s picture

@defsince78: nope - they are different!

The newer version supports playlists that you can navigate through, and assigns the files on a different flashvar (subtle, but means the two are not interchangeable). It has a few other tweaks and refinements. They look very similar, but they are sufficiently different to need modified modules.

@xmacinfo: You get the prize for first confirmed used of 6.x-3.x on a production site! I'm glad you have confidence in the module!! I'm hoping to make a BETA5 this weekend, and this should be it before the final release. Views is in, imagecache is in, fancy FlowPlayer3 playlists are 90% in. Feature addition is going to stop now otherwise this release will never happen. I also want to freeze the module for a while so I can get cracking on 7.x.

At least, I am assuming people would LIKE an SWF Tools 7!?!

Out of curiosity, what is your live site? It's always nice to see what people are doing with SWF Tools :-)

xmacinfo’s picture

Fair enough.

I am pointing to the showcase: http://www.dbn.ca/en/dcmontreal2009

BTW, I tested out playlist as well and I am a bit sad that we need to press play again at the end of each clip.

I had to disable autoplay because sometimes I need to display many videos in a single view, samewise, I learned that most people prefer to press Play.

LuckyBamboo’s picture

OK, I'm just about to give up on this module.... 5 hours and I got just about nowhere.

The only thing i can get working is for the video file to show on a node via a CCK field, but with no play/pause button and no controls. I tried all the tricks i could find on Druapl/Flow player threads , renamed the controls swf file. nothing works!

Also, where i do print swf() i get: "You are missing some Flash content that should appear here! Perhaps your browser cannot display it, or maybe it did not initialize correctly."

I don't mean to sound ungrateful but I've just wasted half a day on this and it's been frustration all the way. what a shame :(

Stuart Greenfield’s picture

Have you tried with a player other than FlowPlayer - although FlowPlayer looks good it can be tricky to set up. JW4 / 5 tends to work a little more reliably "out of the box".

Do you have a sample on a live site where I can see the embedding code that is being produced?

Have you checked your site log for any "page not found" errors - that will tell you if SWF Tools / FlowPlayer are looking for files somewhere other than / named differently to those that you have.

Do bear in mind that there are LOTS of different bits of software all trying to talk to each other, and sometimes there is a simple step that if missed will throw everything out. There's probably something easy to correct - we just have to find it!

edit
Did you check the status page to confirm that you can see the test animation? The status page also gives some messages to show if everything is configured correctly
/edit

LuckyBamboo’s picture

Hi Stuart,
Yes i did check the status page, the animation is working and everything else is marked in green.
I will try your other suggestions and report back.
I understand that this module is a complex one making use of 3rd party software etc... Hopefully, we'll be able to get it to work. I really appreciate your willingness to help me (as well as all the great work you've been doing with this module)!

gibbet’s picture

I've had a couple of issues

1. If i use the default embed technique my flashnodes don't work because things like '&' and ',' which I use in my flash vars and flash var strings respectively get encoded into things flash doesn't recognise.

2. I then used SWFObject2 to place content, this time all my variables go through fine but the load fails (It spits out the you cannot view this sites flash content message) if the $scripts variable is printed at the end of page.tpl.php before $closure kind of like the other bug report from an earlier version (http://drupal.org/node/524944) ...

I'm using beta4 for SWFObject2's autoinstall which works great!

Stuart Greenfield’s picture

I'll double check with flash node interaction. The SWF Tool direct embed encodes flashvars which is how they are supposed to be supplied to a movie, but I'm can't remember if flashnode already encodes. If it's happening twice then that might upset things. I vaguely recall this happening once before...

Stuart Greenfield’s picture

@gibbet - I tested quickly with Flash node and I think the behavior of SWF Tools is right. It parses an incoming flashvars string as if it were a query string, so it uses ampersands to break it in to separate key:value pairs. If a variable needs to contain an ampersand this needs to be encoded by using %26.

When using direct embedding SWF Tools "reassembles" a query string. That sounds convoluted but it's because things like SWF Object 2 want an array, so it's easiest to be sure we pass arrays of flashvars around. When SWF Tools rebuilds the query string it uses drupal_query_string_encode() so things like , will be encoded to %2C.

In essence what you need to do is pass the string from Flashnode to SWF Tools already encoded as a query string (so with characters encoded). SWF Tools will decode this, turn it in to an array as it doesn't know what the end embedding method will be, and then it turns it back in to a string!

Encoding the string is right (see http://kb2.adobe.com/cps/164/tn_16417.html).