Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Please take as much as possible from the Token Extra module.
Thanks! :)
Please take as much as possible from the Token Extra module.
Thanks! :)
Comments
Comment #1
fizk CreditAttribution: fizk commentedComment #2
fizk CreditAttribution: fizk commentedThis is the main part of the module:
Comment #3
Dave ReidWhy did you create the separate project if you wanted it merged into token? :)
Comment #4
fizk CreditAttribution: fizk commentedBecause I love creating new projects! mewhahahahahha
and adding feature requests has always taken a long time and a lot of effort to actually get included into HEAD
and I want this to be available to people right away.
Comment #5
Dave ReidMost of the date tokens already exist. I'm not sure what value the integer, number and string tokens are...
Comment #6
fizk CreditAttribution: fizk commented> Most of the date tokens already exist.
Where? I couldn't find it in the latest stable token module.
> I'm not sure what value the integer, number and string tokens are...
It's the easiest way to get the raw value of a token. I was very frustrated with the lack of this feature, so I created the token_extra module.
Comment #7
Dave ReidLatest code is always in CVS (6.x-1.x-dev), not necessary the latest stable release.
Without some valid use cases, it's hard for me to understand why the integer/number/string tokens are necessary.
Comment #8
fizk CreditAttribution: fizk commentedThe valid use case is very simple, you want to obtain the original/unmodified value of a token. I frequently run into this problem when using Rules module.
There is no way to do this without token_extra right now, AFAIK.
Comment #9
Dave ReidPlease file separate requests for features. Seeing how no one else has needed these tokens and there's only 11 known sites using Token Extra, this isn't something that's a huge priority.
Comment #10
fizk CreditAttribution: fizk commented> Please file separate requests for features.
I'm not sure what you mean, I filed this as a feature request.
> Seeing how no one else has needed these tokens and there's only 11 known sites using Token Extra, this isn't something that's a huge priority.
How many hours does it take to add this functionality? It's already written and the code works properly.
Comment #11
Dave ReidIt's not a proper patch against CVS and doesn't include any simpletests, which is how we accept code into the token.module.
There's four different new features here and it make sense to focus on them individually:
1. account-url-html - Not sure how this is useful.
2. number & string 'passthrough' tokens - should be its own issue
3. date-? tokens - should be its own issue since they need to use the date token helper functions
4. site-date-medium and site-date-large - should be its own issue since it has to modify the date token helper functions