With Comment Notify enabled, clicking the "approve" link (which is provided by Drupal 7) on an unpublished comment does not actually unpublish the comment.

This is due to the fact that Comment Notify implements hook_comment_update() and tries to insert a comment property into its database tables that doesn't exist (because the property is only added on the comment form). This leads to an SQL error, and Drupal responds by rolling back the database transaction.

The attached patch should fix it. I'm guessing there are other bugs that would stem from this as well.

CommentFileSizeAuthor
comment-notify-fix-comment-updates.patch903 bytesDavid_Rothstein
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Status: Active » Needs review

Thanks, David. I'll try to get to this today.

Status: Needs review » Needs work

The last submitted patch, comment-notify-fix-comment-updates.patch, failed testing.

vegantriathlete’s picture

vegantriathlete
he/him/his
Primary language English
Location Lakewood, CO
CreditAttribution: vegantriathlete commented

I was able to verify the behavior you specified. I noticed the behavior both through the approve link on the node itself as well as through the unapproved comments through the content interface.

The patch applied successfully and corrected the problem in both instances.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Title: Comment Notify breaks the core "approve" link (and otherwise prevents updating comments outside the comment form) » Comment Notify breaks the core 'approve' link (and otherwise prevents updating comments outside the comment form)
Status: Needs work » Fixed

Now applied http://drupal.org/cvs?commit=350162

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.