It would be good to use shorten URLs if shorten module is enabled. Here is a patch that does this.

CommentFileSizeAuthor
#2 buzzthis_use_shorten_url.patch655 byteszyxware
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chia’s picture

I think you forgot to attach the patch.

Initially when i developed the module i thought of including the bit.ly api. So that we can track click statistics and display like mashable. But it turns out that bit.ly service is not that good(unless you have pro account).

I didnt get much time to upload that code. I will try to upload the code.

zyxware’s picture

FileSize
655 bytes

Sorry, here is the patch :-)

chia’s picture

Status: Active » Fixed

Added, bit.ly url shorten service and click tracking

anoopjohn’s picture

Status: Fixed » Active

Why is it that buzzthis is using a custom shorten service? Wouldn't it be better to use shorten module which is already being used by other similar modules like tweetmeme, twitter, sexybookmarklets etc and would very likely have shorten already on the site. So even if bitly is a preferred service you would have to configure bitly settings twice in a case where you have bitly via shorten and also via this module.

chia’s picture

Status: Active » Fixed

Bit.ly was used to track the click count. Now, the tracking API is out and there is no need for any url shorten service required. Checkout the latest release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

IceCreamYou’s picture

Version: 6.x-1.4-beta1 » 6.x-2.x-dev
Category: support » feature
Status: Closed (fixed) » Needs review

Hi, I'm the maintainer of the Shorten URLs module.

It would be great if integration with the Shorten URLs module was added to this module. That way people can use services other than bit.ly if they choose to do so -- there's no downside, and the benefit is that people have a greater choice of which service to use.

Thanks

STINGER_LP’s picture

+1, I want use Shorten URLs with this module too!

IceCreamYou’s picture

By the way, since the patch in #2 doesn't apply, I think all that's required for integration is adding these 3 lines after line 67 of buzzthis.module:

if (module_exists('shorten')) {
  $node_url = shorten_url($node_url);
}
chia’s picture

The node url is needed to internally remember the rebuzz count for a post
If we use node/%nid thats better IMO
The 'data-url' attribute internally fetches the buzz counter. The url service or any other service might not work properly in case of url change or new alias and the buzz count will be lost.

IceCreamYou’s picture

Okay I have to be honest, I've never used a Google Buzz button before today, but I went and tried it just now and I have a few thoughts.

First of all, in principle, protecting users from themselves is not in itself a valid reason to decline a feature. So in theory, if people want to use shortened URLs with Buzz, they should have that ability if they choose, even if it's not a great idea in general.

However, I don't really get the point. I thought posting to Buzz would be like posting to Twitter where the URL is part of your post. But from what I tried, it isn't -- so character limits aren't an issue, so there's not really any reason to use a shortened URL.

On the other hand, you can customize the default text in your post using the data-message parameter, which this module currently does not use. If this module starts using that parameter, then some people may want to pre-fill the post text with a shortened URL.

So basically, my now-more-informed opinion is that this feature probably isn't needed right now, but could be useful in the future.

chia’s picture

Buzz is a little different than twitter.

The buzzthis module allows user to share content. When you click on a buzz button. It will link the title to your post, and no url is posted in message and It automatically fetches the teaser. Optionally we can set data-message parameter to use drupal teaser(which is not used currently). IMO i still don't think its needed, using node id will provide consistent counter regardless of changes to url.

In Buzz you can attach images, videos and links to your buzz post. I do plan to use shorten_url token for gbuzz_post module. Where user can post to Buzz from node add / edit form and optionally set a custom message.

anonymous07’s picture

Subscribe

anoopjohn’s picture

Issue summary: View changes

Can we please mark this as Closed (Wont Fix) as the module is no longer relevant.

anoopjohn’s picture

Status: Needs review » Closed (outdated)