The popup only seem to work occasionally for me, when using TinyMCE through the Wysiwyg API module. After editing a node back and forth, it sometimes stops working. Especially if you open the image browser, do nothing, and then close it (with the "close" button). After that, the modal window won't load anymore. The status bar tells me that something is loading when I press it, but nothing happens.

CommentFileSizeAuthor
#19 imagebrowser-no_popup-748430-19.patch1.21 KBckng
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Agence Web CoherActio’s picture

Priority: Normal » Critical

Hi,

Same issue for me with Ckeditor and Wysiwyg API : It displays and works correctly the first time. Then doesn't work anymore if I try to activate it again.

Apparently, the IB window is properly loaded though it is not displayed and positionned properly in the window (display:none at the bottom of the page).

Regards

Laurent

Peter Törnstrand’s picture

Assigned: Unassigned » Peter Törnstrand

I have not been able to reproduce this error. Can you give me any further details as to your setup. Version of jquery_ui (both module and javascript library) and such...

Agence Web CoherActio’s picture

Here are the modules used :

imagebrowser 6.x-2.x-dev as of March 23
jquery_update 6.x-2.x-dev with jquery 1.3.2
wysiwyg 6.x-2.1
ckeditor 6.x-1.1

Thanks

Laurent

pastresbeau’s picture

In the file ib_wysiwyg_init.js,v 1.1.2.3 2010/02/04 15:17:46 blixxxa

if we replace the method invoke in the scope Drupal.wysiwyg.plugins.imagebrowser
by just this :

invoke: function(data, settings, instanceId) {
ib_wysiwyg_dialog_open(instanceId);
},

It seems the dialog opens every time we hit the ckeditor toolbar button
for the imagebrowser plugin. I can't see when it should not open
the dialog in the replaced code.

Peter Törnstrand’s picture

Status: Active » Fixed

Ok. I'll commit this. Commit message.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

chris_huh’s picture

I'm having this problem too.

I used to use the FCKEditor module, but have just switched to WYSIWYG (with CKEditor) to see if that fixes the issue. But it still doesn't load up. It just thinks for a bit then stops, without opening a new window.

I'm using the latest imagebrowser module, which as far as i can see already has the code from #4 in it.

that0n3guy’s picture

Chris,

I was having this issue too.. I realize that my jquery_ui was in the wrong directory (or rather named wrong)... after I fixed that it worked.

***I take it back.. I still have intermittent issues with this as well. I checked and my code does have the commit so this shouldn't be marked as fixed.

that0n3guy’s picture

Status: Closed (fixed) » Active

Ok, how to duplicate this: click the 'image' button... the dialog opens just fine. click the close button instead of adding an image. Click the image button again... it doesn't load... or rather it loads but doesn't show up.

using ckeditor or tinymce with wysiwyg api.

chris_huh’s picture

Hmm, so it still doesn't work for you, but we can duplicate it.

At least its not just me then

Caligan’s picture

Also having this issue, using Wysiwyg dev with the FCKeditor plugin. Has anyone had any luck even getting this to reset? Nothing I've tried has made it function again, which is a huge glaring problem right now.

Peter Törnstrand’s picture

I am not able to reproduce this error using 2.x-DEV.

The important change in the code that resolved this issue for me was:

/**
 * Close jQuery UI dialog box.
 */
function ib_wysiwyg_dialog_close() {
  $("#ib_dialog").remove();
}

in ib_wysiwyg/ib_wysiwyg_init.js.

This is however commited. So if not someone can come up with a way to reproduce this I will close this issue.

dboulet’s picture

I'm experiencing this bug as well, for some reason the callback function for the dialog close button is not being called.

Will investigate...

dboulet’s picture

In my case, this was caused by incompatibilities between my versions of jQuery and jQuery UI.

If using the jquery_update module, make sure that you also update jQuery UI to 1.7 and this problem should go away.

chris_huh’s picture

I've got mine working (well almost). The button is now not greyed out if i use ckeditor or tinymce and when i click on it the popup opens. I think it was upgrading to jQuery 1.7 that made it work.

But the problem i have now is that although the popup opens i can't do anything with it. Whenever i click on an already uploaded image it thinks for a bit and then stops, and also if i click on Close it also thinks for a bit then stops; nothing actually happens. The only thing that does work is uploading a new image, but then i am unable to insert it anyway. It happens in chrome and ff.

Has anyone seen this before?

Update: i've just uninstalled image browser (ie ran the uninstall process) and reinstalled it and its still not working. So it must be some other module affecting it. I've got jQuery Update 6.x-1.1 and jQuery UI 6.x-1.4 (with jquery ui 1.7.3) and am using CKEditor 3.3.1.5586 with the WYSIWYG module (6.x-2.10), if that helps. I've also just updated all the modules and core to the latest versions.

imclean’s picture

I also can't get it to work but I suspect it's the jquery UI version.

Modules:

- jQuery UI 6.x-1.4 with jquery.ui 1.8.4
- wysiwyg API with CKEditor
- jQuery Update 6.x-2.x-dev with jQuery 1.3.2

Using Firefox, upon loading a screen with the WYSIWYG editor and the Image Browser button on it, I see the following message in Firebug:

c.widget is not a function

Clicking on the Image Browse icon generates the following error:

$("#ib_dialog").dialog is not a function
$("#ib_dialog").dialog({ modal: true..._wysiwyg_dialog_close(); } }).show(); 

ib_wysiwyg_init.js, line 16.

Image Browser works with jQuery UI 1.6 - http://drupal.org/node/557912#comment-2787616 presumably because that's the version the jQuery UI module supports.

Peter Törnstrand’s picture

The only supported version of jQuery UI is 1.6.x.

blairCruz’s picture

Was there any resolution to this? I'm experiencing the same issue, I have jqueryui 1.6, jquery update. When I click on the "Insert Images Via Image Browser" button, either through the wysiwyg api, or through the fckeditor pulgin (tested both), the browser thinks for a second then does nothing. I have tested the view and that works correctly, but the browser will never display. Let me know, I really just wanted to test this to see if it is what I need but I can't get it working. Thanks for any help on this.

ckng’s picture

Status: Active » Needs review
FileSize
1.21 KB

Having the same issue. Attached patch solves it for me