Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Admin Toolbar doesn't properly add / remove the toolbar-drawer class when collapsing and expanding the drawer
in toolbar.js the Drupal.toolbar.collapse function adds the toolbar-drawer class.
The Drupal.toolbar.expand function also adds the toolbar-drawer class.
I believe the intention was to have the collapse function remove this class so that themers can have absolute positioning that moves with the expand/collapse of the toolbar.
I've attached a patch that fixes this problem.
| Comment | File | Size | Author |
|---|---|---|---|
| toolbar_drawer.patch | 711 bytes | james.elliott | |
Comments
Comment #1
David_Rothstein CreditAttribution: David_Rothstein commentedLooks good on a quick glance... but this patch is for the D7 core toolbar module, right?
Comment #2
james.elliott CreditAttribution: james.elliott commentedYes, sorry for the incorrect tagging. It was my first bug report.
Comment #3
David_Rothstein CreditAttribution: David_Rothstein commentedHappy first bug report!
I looked at the patch again and tried it out - it works and makes total sense. This should be ready to commit.
Comment #4
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.
Comment #5
jbrown CreditAttribution: jbrown commentedI have often stared at that thinking it did not make sense...
See also #743338: Position of sticky table headers is not updated when shortcut bar is toggled