It is often useful to be able to inherit existing tests instead of deriving from DrupalWebTestCase, and private methods in HelpTestCase prevent this.

Since the visibility use case is limited to inherited tests, the suggested patch changes them to protected, not public.

CommentFileSizeAuthor
protected_test.patch1.05 KBfgm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Damien Tournoud’s picture

Damien Tournoud CreditAttribution: Damien Tournoud commented
Status: Needs review » Reviewed & tested by the community

Yep, that's consistent with what we do elsewhere.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, protected_test.patch, failed testing.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs work » Needs review

protected_test.patch queued for re-testing.

Damien Tournoud’s picture

Damien Tournoud CreditAttribution: Damien Tournoud commented
Status: Needs review » Reviewed & tested by the community
Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.