Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The big hook definition for plugins should be changing slightly in the upcoming release of ctools. The attached patch is a backwards compatible solution to continue using this style definition going forward.
It may be a larger issue but the way they're currently being included with the include and the second function might be eased by using the preferred per plugin includes method. In that case, the attached patch would not me needed.
Related issue: #711664: Make global plugins definition hooks optional
Comment | File | Size | Author |
---|---|---|---|
openlayers_use_ctools_deprecated_big_hook_definition-HEAD.patch | 730 bytes | neclimdul | |
openlayers_use_ctools_deprecated_big_hook_definition-6--2.patch | 826 bytes | neclimdul | |
Comments
Comment #1
zzolo CreditAttribution: zzolo commentedI have tested this patch for 2.x and current stable ctools: seems fine.
Testing with ctools HEAD: I get an unrelated ctools error.
Comment #2
tmcw CreditAttribution: tmcw commentedIssues with patches are the best :). Should we expand this to cover layer types, etc?
Comment #3
neclimdulOh, if there's a plugin type I missed, probably. Sorry, I actually wrote this patch from the hip based grep and the the ctools api and didn't test it since I'm not terribly familiar with the inner workings of openlayers.
I don't believe the other issue has been committed so to /really/ give it a good test you probably want to apply that patch to ctools HEAD as well.
Comment #4
tmcw CreditAttribution: tmcw commentedCommitted: http://drupal.org/cvs?commit=363416