module_implements() currently fails to detect an include file if the file is already loaded during cache building. That way hook implementations are missed when the file then isn't loaded during another page request.

Attached a fix including a test for that.

CommentFileSizeAuthor
#2 module_implements_fix_0.patch3.35 KBfago
#1 module_implements_fix.patch3.35 KBfago
module_implements_fix.patch2.86 KBfago
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago commented
FileSize
module_implements_fix.patch3.35 KB

I noted the added file for the test was missing in the patch. Added it.

fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago commented
FileSize
module_implements_fix_0.patch3.35 KB

Hello bot, please test my patch!

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs review » Reviewed & tested by the community

Looks sensible, code only runs on cache rebuild so no particular reason to check module_hook() first.

fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago commented

Any chance to get this committed soon? :)

I'm using that grouping functionality for rules and without that patch rules won't find its files after a cache rebuild.

realityloop’s picture

realityloop
he/him
CreditAttribution: realityloop commented

#2: module_implements_fix_0.patch queued for re-testing.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.