Along with #731558: Use taxonomy_save_term() for all CRUD functionality, it would also greatly simplify many other efforts if taxonomy_manager just used taxonomy_form_term() for the forms instead of building its own.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna’s picture

Here's a patch against CVS. So far I've gotten the form itself to show up and work correctly (I think), the next step is handling the saving. Note: right now the save action just returns print_r($_POST) and exits, so it won't save anything.

Anonymous’s picture

Does this end up breaking integration with term relation types module? http://drupal.org/project/term_relation_types

DamienMcKenna’s picture

I'd never seen that one before.. I'll give it a look after getting this core functionality working first.

DamienMcKenna’s picture

Status: Active » Needs work
mh86’s picture

how would the form look like? can you provide a screenshot?

DamienMcKenna’s picture

It would be the normal taxonomy term form.

Current limitations:

  • It would need further tweaking to use taxonomy_manager's existing autocomplete fields rather than the select boxes from Drupal core.
  • Collapsed frames don't work, and manually executing Drupal.behaviors.collapse() causes the page to mess up; as a stop-gap my patch currently sets collapsed=FALSE for all fieldsets.
DamienMcKenna’s picture

An updated patch that passes tid and vid as hidden fields rather than values (which don't show on the form itself).

Anonymous’s picture

Damien:

The reason I asked about term relation types is that it hooks into the taxonomy manager form (and custom modules of mine do as well) but it doesn't hook into the core taxonomy term form.

If this work unifies everything, wonderful. But if it breaks support for the other modules that hook into taxonomy manager's editor, I worry that it may not go far.

ivnish’s picture

Issue summary: View changes
Status: Needs work » Closed (outdated)